Skip to content

tools: enable linter on some fixtures file #57674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

tools: enable linter on some fixtures file #57674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
} from './tools/eslint/eslint.config_utils.mjs';
import nodeCore from './tools/eslint/eslint-plugin-node-core.js';

const { globalIgnores } = await importEslintTool('eslint/config');
const { default: js } = await importEslintTool('@eslint/js');
const { default: babelEslintParser } = await importEslintTool('@babel/eslint-parser');
const babelPluginSyntaxImportAttributes = resolveEslintTool('@babel/plugin-syntax-import-attributes');
Expand All @@ -39,19 +40,22 @@ Module._resolveFilename = (request, parent, isMain, options) => {

export default [
// #region ignores
{
ignores: [
'**/node_modules/**',
'benchmark/fixtures/**',
'benchmark/tmp/**',
'doc/changelogs/CHANGELOG_V1*.md',
'!doc/changelogs/CHANGELOG_V18.md',
'lib/punycode.js',
'test/.tmp.*/**',
'test/addons/??_*',
'test/fixtures/**',
],
},
globalIgnores([
'**/node_modules/**',
'benchmark/fixtures/**',
'benchmark/tmp/**',
'doc/changelogs/CHANGELOG_V1*.md',
'!doc/changelogs/CHANGELOG_V18.md',
'lib/punycode.js',
'test/.tmp.*/**',
'test/addons/??_*',

// We want to lint only a few specific fixtures folders
'test/fixtures/*',
'!test/fixtures/console',
'!test/fixtures/v8',
'!test/fixtures/vm',
]),
// #endregion
// #region general config
js.configs.recommended,
Expand Down
2 changes: 1 addition & 1 deletion test/eslint.config_partial.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default [
},
{
files: [
'test/{common,wpt}/**/*.{js,mjs,cjs}',
'test/{common,fixtures,wpt}/**/*.{js,mjs,cjs}',
'test/eslint.config_partial.mjs',
],
rules: {
Expand Down
Loading