src: improve StringBytes error handling #57706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/string_bytes
branch
from
1fab9ca to
715f9ae
Compare
anonrig
reviewed
Apr 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Apr 3, 2025
jasnell
added
the
author ready
aduh95
reviewed
Apr 5, 2025
Comment on lines
+188
to
-196
| args.GetReturnValue().Set(ret); | ||
| } | ||
|
|
||
| args.GetReturnValue().Set(ret); |
There was a problem hiding this comment.
nit: I'd find it more readable to return on the error path, possibly with a comment, and keep the .Set() call on the top-level of the body of the function
aduh95
approved these changes
Apr 6, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 93644d5 |
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
PR-URL: nodejs#57706 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57706 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57706 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Could you open a backport PR to v22.x-staging please? |
aduh95
added
the
backport-requested-v22.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling and the signature of
StringBytes::Encode(...).Also, mark the
node::Encode(...)C++ APIs as deprecated since those do not propagate errors correctly. Addednode::TryEncode(...)replacements that properly returnMaybeLocal<String>and propagate errors.