nodejs · targos · Apr 15, 2025 · Apr 15, 2025 · Apr 15, 2025 · Sep 21, 2022
diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml
@@ -36,7 +36,6 @@ on:
           - postject
           - root-certificates
           - simdjson
-          - simdutf
           - sqlite
           - undici
           - uvwasi
@@ -244,14 +243,6 @@ jobs:
               cat temp-output
               tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
               rm temp-output
-          - id: simdutf
-            subsystem: deps
-            label: dependencies
-            run: |
-              ./tools/dep_updaters/update-simdutf.sh > temp-output
-              cat temp-output
-              tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
-              rm temp-output
           - id: sqlite
             subsystem: deps
             label: dependencies, sqlite

diff --git a/LICENSE b/LICENSE
@@ -1489,7 +1489,7 @@ The externally maintained libraries used by Node.js are:
         This code is copyrighted by Sun Microsystems Inc. and released
         under a 3-clause BSD license.
 
-      - Valgrind client API header, located at src/third_party/valgrind/valgrind.h
+      - Valgrind client API header, located at third_party/valgrind/valgrind.h
         This is released under the BSD license.
 
       - The Wasm C/C++ API headers, located at third_party/wasm-api/wasm.{h,hh}
@@ -1774,7 +1774,7 @@ The externally maintained libraries used by Node.js are:
        limitations under the License.
   """
 
-- simdutf, located at deps/simdutf, is licensed as follows:
+- simdutf, located at deps/v8/third_party/simdutf, is licensed as follows:
   """
     Copyright 2021 The simdutf authors
 

diff --git a/Makefile b/Makefile
@@ -654,10 +654,6 @@ test-internet: all ## Run internet tests.
 test-tick-processor: all ## Run tick processor tests.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) tick-processor
 
-.PHONY: test-hash-seed
-test-hash-seed: all ## Verifu that the hash seed used by V8 for hashing is random.
-	$(NODE) test/pummel/test-hash-seed.js
-
 .PHONY: test-doc
 test-doc: doc-only lint-md ## Build, lint, and verify the docs.
 	@if [ "$(shell $(node_use_openssl_and_icu))" != "true" ]; then \
@@ -751,8 +747,6 @@ test-v8: v8  ## Run the V8 test suite on deps/v8.
 				mjsunit cctest debugger inspector message preparser \
 				$(TAP_V8)
 	$(call convert_to_junit,$(TAP_V8_JSON))
-	$(info Testing hash seed)
-	$(MAKE) test-hash-seed
 
 test-v8-intl: v8 ## Run the v8 test suite, intl tests.
 	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
@@ -768,7 +762,7 @@ test-v8-benchmarks: v8 ## Run the v8 test suite, benchmarks.
 				$(TAP_V8_BENCHMARKS)
 	$(call convert_to_junit,$(TAP_V8_BENCHMARKS_JSON))
 
-test-v8-updates: ## Run the v8 test suite, updates.
+test-v8-updates: all ## Run the v8 test suite, updates.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) v8-updates
 
 test-v8-all: test-v8 test-v8-intl test-v8-benchmarks test-v8-updates ## Run the entire V8 test suite, including intl, benchmarks, and updates.
@@ -949,9 +943,6 @@ else
 ifeq ($(findstring s390x,$(UNAME_M)),s390x)
 DESTCPU ?= s390x
 else
-ifeq ($(findstring s390,$(UNAME_M)),s390)
-DESTCPU ?= s390
-else
 ifeq ($(findstring OS/390,$(shell uname -s)),OS/390)
 DESTCPU ?= s390x
 else
@@ -985,7 +976,6 @@ endif
 endif
 endif
 endif
-endif
 ifeq ($(DESTCPU),x64)
 ARCH=x64
 else
@@ -998,9 +988,6 @@ else
 ifeq ($(DESTCPU),ppc64)
 ARCH=ppc64
 else
-ifeq ($(DESTCPU),s390)
-ARCH=s390
-else
 ifeq ($(DESTCPU),s390x)
 ARCH=s390x
 else
@@ -1018,7 +1005,6 @@ endif
 endif
 endif
 endif
-endif
 
 # node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
 # pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.

diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc
@@ -21,7 +21,7 @@ void CallWithString(const FunctionCallbackInfo<Value>& args) {
   assert(args.Length() == 1 && args[0]->IsString());
   if (args.Length() == 1 && args[0]->IsString()) {
     Local<String> str = args[0].As<String>();
-    const int32_t length = str->Utf8Length(args.GetIsolate()) + 1;
+    const size_t length = str->Utf8LengthV2(args.GetIsolate()) + 1;
     char* buf = new char[length];
     str->WriteUtf8(args.GetIsolate(), buf, length);
     delete[] buf;

diff --git a/common.gypi b/common.gypi
@@ -38,7 +38,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.12',
+    'v8_embedder_string': '-node.11',
 
     ##### V8 defaults for Node.js #####
 
@@ -568,6 +568,7 @@
           }],
           [ 'node_shared=="true"', {
             'cflags': [ '-fPIC' ],
+            'ldflags': [ '-fPIC' ],
           }],
         ],
       }],

diff --git a/configure.py b/configure.py
@@ -640,12 +640,6 @@
     default=None,
     help='[Experimental] Enable V8 pointer compression (limits max heap to 4GB and breaks ABI compatibility)')
 
-parser.add_argument('--disable-shared-readonly-heap',
-    action='store_true',
-    dest='disable_shared_ro_heap',
-    default=None,
-    help='Disable the shared read-only heap feature in V8')
-
 parser.add_argument('--v8-options',
     action='store',
     dest='v8_options',
@@ -1720,7 +1714,6 @@ def configure_v8(o, configs):
   o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
   o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0
   o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
-  o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
   o['variables']['v8_enable_extensible_ro_snapshot'] = 0
   o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
   o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)

diff --git a/deps/simdutf/BUILD.gn b/deps/simdutf/BUILD.gn
diff --git a/deps/simdutf/README.md b/deps/simdutf/README.md
diff --git a/deps/simdutf/simdutf.gyp b/deps/simdutf/simdutf.gyp
diff --git a/deps/simdutf/unofficial.gni b/deps/simdutf/unofficial.gni
diff --git a/deps/v8/.bazelrc b/deps/v8/.bazelrc
@@ -2,10 +2,14 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+# Enable Bzlmod for every Bazel command
+common --enable_bzlmod
+
 # Pass CC, CXX and PATH from the environment
 build --action_env=CC
 build --action_env=CXX
 build --action_env=PATH
+build --copt=-std=c++20
 
 # Use Clang compiler
 build:clang --action_env=BAZEL_COMPILER=clang
@@ -17,7 +21,8 @@ build:debug --compilation_mode=dbg
 build:debug --config=v8_enable_debugging_features
 build:debug --//:v8_enable_fast_mksnapshot
 build:debug --//:v8_enable_backtrace
-build:debug --//:v8_enable_handle_zapping
+build:debug --//:v8_enable_local_handle_zapping
+build:debug --//:v8_enable_global_handle_zapping
 
 # v8_enable_debugging_features flags
 build:v8_enable_debugging_features --//:v8_enable_verify_heap

diff --git a/deps/v8/.clang-tidy b/deps/v8/.clang-tidy
@@ -9,7 +9,9 @@
                     modernize-redundant-void-arg,
                     modernize-replace-random-shuffle,
                     modernize-shrink-to-fit,
+                    modernize-type-traits,
                     # modernize-use-auto,
+                    modernize-use-constraints,
                     modernize-use-bool-literals,
                     modernize-use-equals-default,
                     # modernize-use-equals-delete,

diff --git a/deps/v8/.gitignore b/deps/v8/.gitignore
@@ -82,14 +82,21 @@
 /third_party/googletest/src/googletest/include/gtest/*
 !/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
 !/third_party/highway
-/third_party/highway/src
+/third_party/highway/src/*
+!/third_party/highway/src/hwy
 !/third_party/inspector_protocol
 !/third_party/jsoncpp
 /third_party/jsoncpp/source
+!/third_party/llvm-libc
+/third_party/llvm-libc/src
+!/third_party/rapidhash-v8
 !/third_party/re2
 /third_party/re2/src
-!/third_party/test262-harness
+!/third_party/siphash
+!/third_party/utf8-decoder
 !/third_party/v8
+!/third_party/valgrind
+!/third_party/vtune
 !/third_party/wasm-api
 /tools/builtins-pgo/profiles/*
 !/tools/builtins-pgo/profiles/.*
@@ -103,6 +110,7 @@
 /tools/oom_dump/oom_dump
 /tools/oom_dump/oom_dump.o
 /tools/protoc_wrapper
+/tools/rust
 /tools/turbolizer/build
 /tools/turbolizer/.rpt2_cache
 /tools/turbolizer/deploy
@@ -145,3 +153,4 @@ bazel-v8
 !/third_party/fp16
 /third_party/fp16/src/*
 !/third_party/fp16/src/include
+!/third_party/simdutf
diff --git a/deps/v8/.gn b/deps/v8/.gn
@@ -27,8 +27,9 @@ no_check_targets = [
 default_args = {
   # Disable js dependencies like the closure compiler.
   enable_js_protobuf = false
+
   # Disable rust dependencies.
-  enable_rust = false
+  enable_rust = true
 }
 
 # These are the list of GN files that run exec_script. This whitelist exists

diff --git a/deps/v8/AUTHORS b/deps/v8/AUTHORS
@@ -57,8 +57,9 @@ Alexander Botero-Lowry <alexbl@FreeBSD.org>
 Alexander Karpinsky <homm86@gmail.com>
 Alexander Neville <dark@volatile.bz>
 Alexandre Vassalotti <avassalotti@gmail.com>
-Alexey Pavlyutkin <alexey.pavlyutkin.community@gmail.com>
+Alexey Pavlyutkin <alexey.pavlyutkin@syntacore.com>
 Alexis Campailla <alexis@janeasystems.com>
+Aliya Minimullina <a.minimullina@syntacore.com>
 Allan Sandfeld Jensen <allan.jensen@qt.io>
 Amos Lim <eui-sang.lim@samsung.com>
 Andreas Anyuru <andreas.anyuru@gmail.com>
@@ -120,6 +121,7 @@ Dominic Farolini <domfarolino@gmail.com>
 Douglas Crosher <dtc-v8@scieneer.com>
 Dusan Milosavljevic <dusan.m.milosavljevic@gmail.com>
 Eden Wang <nedenwang@tencent.com>
+Edoardo Marangoni <edoardo@wasmer.io>
 Elisha Hollander <just4now666666@gmail.com>
 Eric Rannaud <eric.rannaud@gmail.com>
 Erich Ocean <erich.ocean@me.com>
@@ -210,11 +212,13 @@ Maxim Mazurok <maxim@mazurok.com>
 Maxim Mossienko <maxim.mossienko@gmail.com>
 Md Hasibul Hasan <hasibulhasan873@gmail.com>
 Meir Shpilraien <meir@redis.com>
+Meng Tan <tannal2409@gmail.com>
 Michael Lutz <michi@icosahedron.de>
 Michael Mclaughlin <m8ch88l@gmail.com>
 Michael Smith <mike@w3.org>
 Michaël Zasso <mic.besace@gmail.com>
 Mihir Shah <mihirshah.11204@gmail.com>
+Mika Fischer <mika.fischer@zoopnet.de>
 Mike Gilbert <floppymaster@gmail.com>
 Mike Pennisi <mike@mikepennisi.com>
 Mikhail Gusarov <dottedmag@dottedmag.net>
@@ -268,6 +272,7 @@ Sébastien Doeraene <sjrdoeraene@gmail.com>
 Seo Sanghyeon <sanxiyn@gmail.com>
 Shawn Anastasio <shawnanastasio@gmail.com>
 Shawn Presser <shawnpresser@gmail.com>
+Sho Miyamoto <me@shqld.dev>
 Stefan Penner <stefan.penner@gmail.com>
 Stefan Stojanovic <stefko.stojanovic@gmail.com>
 Stephan Hartmann <stha09@googlemail.com>
@@ -290,6 +295,7 @@ Varun Varada <varuncvarada@gmail.com>
 Victor Costan <costan@gmail.com>
 Victor Polevoy <fx@thefx.co>
 Vlad Burlik <vladbph@gmail.com>
+Vladimir Kempik <vladimir.kempik@syntacore.com>
 Vladimir Krivosheev <develar@gmail.com>
 Vladimir Shutoff <vovan@shutoff.ru>
 Wael Almattar <waelsy123@gmail.com>
@@ -303,6 +309,7 @@ Wiktor Garbacz <wiktor.garbacz@gmail.com>
 Wouter Vermeiren <wouter.vermeiren@essensium.com>
 Xiaofang Zou <zouxiaofang@iscas.ac.cn>
 Xiaoyin Liu <xiaoyin.l@outlook.com>
+Yagiz Nizipli <yagiz@nizipli.com>
 Yanbo Li <lybvinci@gmail.com>
 Yannic Bonenberger <contact@yannic-bonenberger.com>
 Yi Wang <wangyi8848@gmail.com>
@@ -317,6 +324,7 @@ Yuxiang Cao <caoyxsh@outlook.com>
 Zac Hansen <xaxxon@gmail.com>
 Zeynep Cankara <zeynepcankara402@gmail.com>
 Zhao Jiazhong <kyslie3100@gmail.com>
+Zhao Qin <qzmiss@gmail.com>
 Zhaojun Meng <zhaojun.meng@gmail.com>
 Zheng Liu <i6122f@gmail.com>
 Zhongping Wang <kewpie.w.zp@gmail.com>
@@ -325,3 +333,4 @@ Yang Xiang <xiangyangemail@gmail.com>
 Kotaro Ohsugi <dec4m4rk@gmail.com>
 Jing Peiyang <jingpeiyang@eswincomputing.com>
 magic-akari <akari.ccino@gmail.com>
+Ryuhei Shima <shimaryuhei@gmail.com>
diff --git a/test/sequential/test-error-serdes.js b/test/sequential/test-error-serdes.js
 // Flags: --expose-internals --stack-size=64
 'use strict';
 require('../common');
 const assert = require('assert');
diff --git a/test/parallel/test-stream-readable-unpipe-resume.js b/test/parallel/test-stream-readable-unpipe-resume.js
 'use strict';

 const common = require('../common');
 const stream = require('stream');
	// Flags: --expose-internals --stack-size=64
Check failure on line 1 in test/sequential/test-error-serdes.js GitHub Actions / test-macOS --- stderr --- node:internal/streams/readable:90 const FastBuffer = Buffer[SymbolSpecies]; ^ RangeError: Maximum call stack size exceeded at node:internal/streams/readable:90:26 at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7) at requireBuiltin (node:internal/bootstrap/realm:429:14) at node:internal/streams/duplex:39:18 at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7) at requireBuiltin (node:internal/bootstrap/realm:429:14) at node:internal/streams/pipeline:16:16 at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7) at requireBuiltin (node:internal/bootstrap/realm:429:14) at node:internal/streams/compose:7:22 Node.js v24.0.0-pre Command: out/Release/node --expose-internals --stack-size=64 --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/runner/work/node/node/node/test/sequential/test-error-serdes.js
	'use strict';
	require('../common');
	const assert = require('assert');
	'use strict';
Check failure on line 1 in test/parallel/test-stream-readable-unpipe-resume.js GitHub Actions / test-linux (ubuntu-24.04-arm) Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout "/home/runner/work/node/node/dir%20with $unusual"chars?'åß∂ƒ©∆¬…`/test/parallel/test-stream-readable-unpipe-resume.js" --- TIMEOUT ---

	const common = require('../common');
	const stream = require('stream');