Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of 5528 #5785

Closed
wants to merge 2 commits into from
Closed

Backport of 5528 #5785

wants to merge 2 commits into from

Commits on Mar 18, 2016

  1. tools: support testing known issues 

    This commit adds a known_issues directory to the test directory
for scripts that reproduce known bugs. Since these scripts are
expected to fail, it also adds a --expect-fail flag to test.py
which reports tests as successful when they fail.

Refs: nodejs/testing#18
PR-URL: nodejs#5528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Conflicts:
	tools/test.py
    @cjihrig
    cjihrig committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    4b04cb4 View commit details
    Browse the repository at this point in the history

  2. test: bug repro for vm function redefinition 

    This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.

Refs: nodejs#548
PR-URL: nodejs#5528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @cjihrig
    cjihrig committed Mar 18, 2016
    Configuration menu
    Copy the full SHA
    bab9aaf View commit details
    Browse the repository at this point in the history