-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
lib,tools: rename functions named value
#57901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
it'd be great to get a PR that just fixes the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57901 +/- ##
==========================================
- Coverage 89.97% 89.96% -0.01%
==========================================
Files 649 649
Lines 192202 192198 -4
Branches 37689 37671 -18
==========================================
- Hits 172932 172913 -19
- Misses 11869 11877 +8
- Partials 7401 7408 +7
🚀 New features to boost your workflow:
|
8345a46
to
c969ef7
Compare
Hello, I've worked on the eslint rule for this one, i've just made some changes with the eslint's You can check the work here: lib-name-functions Let me know if you guys have any thoughts on this :>, and if all is good, i could send a PR to this PR's branch. |
@louiellan sorry for the late response.
Yes, the code in your branch LGTM!
Small adjustments:
- the test's filename should start with `test-`, i.e. `func-name-matching.test.js` should be renamed to something like `test-eslint-func-name-matching.js`.
- i think the `@author` comments should be in separate lines (with multiple `@author` tags) rather than comma-separated.
Please feel free to open a PR either against this branch, or directly against main branch (not preserving my commit is also okay). Or i can merge your commits into this PR once am on PC (probably mid-August). Thank you!
|
@LiviaMedeiros I've made the adjustments and here's the pull request to your branch, LiviaMedeiros#1 |
with the node-core/func-name-matching rule
8403844
to
cb53cff
Compare
value
value
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #57899
This PR adds a
node-core/func-name-matching
linter rule that correctly handles defining properties with functions asvalue
, and fixes the function names accordingly.Authored by @louiellan