build: remove redundant -mXX flags for V8
#57907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are already set by `common.gypi`.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This comment was marked as resolved.
This comment was marked as resolved.
jasnell
approved these changes
Apr 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
marco-ippolito
approved these changes
Apr 18, 2025
legendecas
approved these changes
Apr 18, 2025
RafaelGSS
approved these changes
Apr 18, 2025
targos
added
author ready
lpinca
approved these changes
Apr 18, 2025
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57907 ✔ Done loading data for nodejs/node/pull/57907 ----------------------------------- PR info ------------------------------------ Title build: remove redundant `-mXX` flags for V8 (#57907) Author Michaël Zasso <targos@protonmail.com> (@targos) Branch targos:m32-64 -> nodejs:main Labels v8 engine, tools, author ready, needs-ci Commits 2 - build: remove redundant `-mXX` flags for V8 - fixup: remove now unused variables Committers 1 - Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/57907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 17 Apr 2025 09:39:13 GMT ✔ Approvals: 5 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2775831274 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778577919 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778623340 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57907#pullrequestreview-2778639380 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57907#pullrequestreview-2779209617 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-18T12:46:51Z: https://ci.nodejs.org/job/node-test-pull-request/66347/ - Querying data for job/node-test-pull-request/66347/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 57907 From https://github.com/nodejs/node * branch refs/pull/57907/merge -> FETCH_HEAD ✔ Fetched commits as 63640eb32d58..3b7d17ee2892 -------------------------------------------------------------------------------- [main b275a7eb38] build: remove redundant `-mXX` flags for V8 Author: Michaël Zasso <targos@protonmail.com> Date: Thu Apr 17 11:38:23 2025 +0200 1 file changed, 64 deletions(-) [main d098d40c0b] fixup: remove now unused variables Author: Michaël Zasso <targos@protonmail.com> Date: Thu Apr 17 11:40:05 2025 +0200 1 file changed, 27 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- build: remove redundant `-mXX` flags for V8https://github.com/nodejs/node/actions/runs/14547939233 |
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2b76dca |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
They are already set by `common.gypi`. PR-URL: #57907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
They are already set by `common.gypi`. PR-URL: #57907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added
the
dont-land-on-v20.x
aduh95
added
the
dont-land-on-v22.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are already set by
common.gypi.