[v22.x backport] src: add config file support #57958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aduh95 merged 5 commits into nodejs:v22.x-staging from marco-ippolito:backport-config-file

May 6, 2025

Member

marco-ippolito commented Apr 21, 2025

No description provided.

Collaborator

nodejs-github-bot commented Apr 21, 2025

Review requested:

@nodejs/config
@nodejs/gyp
@nodejs/startup

nodejs-github-bot added lib / src needs-ci v22.x labels

marco-ippolito added the config label

marco-ippolito force-pushed the backport-config-file branch from e5a01b1 to e24e436 Compare

April 21, 2025 08:34

Collaborator

nodejs-github-bot commented Apr 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66426/

Member Author

marco-ippolito commented Apr 24, 2025

I noticed I cherry-pick commit without metadata 😫

marco-ippolito force-pushed the backport-config-file branch from e24e436 to 3db769a Compare

April 24, 2025 15:19

Collaborator

nodejs-github-bot commented Apr 28, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66497/

RafaelGSS approved these changes

View reviewed changes

Member

RafaelGSS left a comment

LGTM

Contributor

aduh95 commented May 6, 2025

To get backlinks to the PRs being backported:

marco-ippolito added 5 commits

May 6, 2025 22:20


          src: add config file support

b3bdf0f

PR-URL: nodejs#57016
Backport-PR-URL: nodejs#57958
Refs: nodejs#53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

d8cf8d2

PR-URL: nodejs#57016
Backport-PR-URL: nodejs#57958
Refs: nodejs#53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>


          src: namespace config file flags

143064b

PR-URL: nodejs#57170
Backport-PR-URL: nodejs#57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>


          test: add more coverage to node_config_file

a6cff20

PR-URL: nodejs#57170
Backport-PR-URL: nodejs#57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>


          src: set default config as node.config.json

64a157f

PR-URL: nodejs#57171
Backport-PR-URL: nodejs#57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 force-pushed the backport-config-file branch from 3db769a to 64a157f Compare

May 6, 2025 20:28

aduh95 merged commit 64a157f into nodejs:v22.x-staging

13 of 19 checks passed

Contributor

aduh95 commented May 6, 2025 •

edited

Loading

Landed in e35638d...8e58fbe

aduh95 pushed a commit that referenced this pull request


          src: add config file support

cc6fef9

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

8f36a2c

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

0545e1b

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

8e58fbe

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request


          src: add config file support

cb92a2a

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

RafaelGSS pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

d77e25d

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

RafaelGSS pushed a commit that referenced this pull request


          src: namespace config file flags

9ff58d5

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

RafaelGSS pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

033127c

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

RafaelGSS pushed a commit that referenced this pull request


          src: set default config as node.config.json

914a4d5

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

c874310

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

8f6beba

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

287a0c1

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

e004de5

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

1c66278

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

262bbfd

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

c4d59a6

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

c75bc27

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

6a7087e

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

c360282

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

d0f895d

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

275b227

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

53e93c2

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

188ad24

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

fc9f75b

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

e338c8f

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

3612f2d

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

c8c3872

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

a7e7b7e

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

2d4111f

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

5d31350

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

ec4201d

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

e24076d

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

e85580d

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request


          src: add config file support

0350c6f

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: create THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING

30bb1cc

PR-URL: #57016
Backport-PR-URL: #57958
Refs: #53787
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: namespace config file flags

ccee741

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          test: add more coverage to node_config_file

e90583b

PR-URL: #57170
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

aduh95 pushed a commit that referenced this pull request


          src: set default config as node.config.json

5d1230b

PR-URL: #57171
Backport-PR-URL: #57958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config lib / src needs-ci v22.x