Skip to content

doc: reserve module version 136 for Electron 37 #57979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

doc: reserve module version 136 for Electron 37 #57979

merged 1 commit into from
Apr 24, 2025

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Apr 22, 2025

This PR reserves NMV 136 for Electron 37 as part of our regular release preparation work. Thanks! 🙇

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 22, 2025
mhdawson
mhdawson approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4c764c8 into nodejs:main Apr 24, 2025
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4c764c8

@clavin clavin deleted the clavin/doc-electron-37-abi-136 branch April 24, 2025 22:43
@clavin clavin mentioned this pull request Apr 24, 2025
Merged
@joyeecheung joyeecheung mentioned this pull request Apr 25, 2025
Closed
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@clavin @RafaelGSS
doc: reserve module version 136 for Electron 37
edf1621 
PR-URL: #57979
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@clavin @RafaelGSS
doc: reserve module version 136 for Electron 37
352df16 
PR-URL: #57979
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@clavin @nodejs-github-bot @lpinca @UlisesGascon @richardlau @mhdawson @aduh95