Skip to content

deps: update V8 to 13.6 #58070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 39 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
e04b976
deps: update V8 to 13.6.233.8
targos Apr 29, 2025
038c3f2
build: reset embedder string to "-node.0"
targos Apr 29, 2025
045507c
src: update NODE_MODULE_VERSION to 137
targos Apr 29, 2025
2b27576
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
d6837f1
deps: fix FP16 bitcasts.h
StefanStojanovic May 28, 2024
8a9baf6
deps: define V8_PRESERVE_MOST as no-op on Windows
StefanStojanovic Dec 16, 2024
1f9cf1d
deps: remove problematic comment from v8-internal
targos Mar 19, 2025
3deb96e
deps: patch V8 for illumos
danmcd Apr 18, 2025
ee7ad80
deps: use std::map in MSVC STL for EphemeronRememberedSet
joyeecheung Apr 28, 2025
567d78c
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
ca3fffb
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
eabc4fb
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
36ee451
deps: V8: backport 954187bb1b87
joyeecheung Apr 24, 2025
840fbbb
build: remove support for s390 32-bit
richardlau Sep 18, 2024
eb26ca3
build: enable shared RO heap with ptr compression
targos Sep 21, 2024
c08834a
tools: update V8 gypfiles for 13.1
targos Sep 25, 2024
0c4f35c
tools: update V8 gypfiles for 13.2
targos Oct 28, 2024
d7d2b59
build,src,tools: adapt build config for V8 13.3
targos Dec 19, 2024
9afc83f
tools: update V8 gypfiles for 13.4
targos Jan 20, 2025
f552e07
build: add `/bigobj` to compile V8 on Windows
targos Feb 5, 2025
b247c98
src: replace uses of FastApiTypedArray
targos Feb 8, 2025
38be4b8
Revert "test: disable fast API call count checks"
targos Jan 31, 2025
3e314b4
test: update test-linux-perf-logger
targos Feb 4, 2025
34b439a
test: adapt assert tests to stack trace changes
targos Dec 20, 2024
9297f92
test: handle explicit resource management globals
targos Dec 21, 2024
50db68a
deps: remove deps/simdutf
targos Jan 29, 2025
e7504c7
tools: update license-builder and LICENSE for V8 deps
targos Jan 29, 2025
6b6add6
src: use `v8::ExternalMemoryAccounter`
targos Feb 15, 2025
9c9f865
src,test: add V8 API to test the hash seed
targos Feb 20, 2025
07cdd3b
build: pass `-fPIC` to linker as well for shared builds
targos Apr 2, 2025
adc9675
build: fix V8 TLS config for shared lib builds
targos Apr 3, 2025
773a8c6
tools: update V8 gypfiles for 13.5
targos Feb 25, 2025
2e71fb7
tools: update V8 gypfiles for 13.6
targos Apr 5, 2025
8a3e8f3
build: update list of installed cppgc headers
targos Apr 6, 2025
6f16029
test: fix test-fs-write for V8 13.6
targos Apr 9, 2025
1780962
src: use V8-owned CppHeap
joyeecheung May 29, 2024
05054d2
src: use non-deprecated Utf8LengthV2() method
anonrig Apr 17, 2025
c21b0e7
src: use non-deprecated WriteUtf8V2() method
anonrig Apr 17, 2025
fb09a88
src,test: unregister the isolate after disposal and before freeing
joyeecheung Apr 21, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
9 changes: 0 additions & 9 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ on:
- postject
- root-certificates
- simdjson
- simdutf
- sqlite
- undici
- uvwasi
Expand Down Expand Up @@ -244,14 +243,6 @@ jobs:
cat temp-output
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
rm temp-output
- id: simdutf
subsystem: deps
label: dependencies
run: |
./tools/dep_updaters/update-simdutf.sh > temp-output
cat temp-output
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
rm temp-output
- id: sqlite
subsystem: deps
label: dependencies, sqlite
Expand Down
4 changes: 2 additions & 2 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ The externally maintained libraries used by Node.js are:
This code is copyrighted by Sun Microsystems Inc. and released
under a 3-clause BSD license.

- Valgrind client API header, located at src/third_party/valgrind/valgrind.h
- Valgrind client API header, located at third_party/valgrind/valgrind.h
This is released under the BSD license.

- The Wasm C/C++ API headers, located at third_party/wasm-api/wasm.{h,hh}
Expand Down Expand Up @@ -1774,7 +1774,7 @@ The externally maintained libraries used by Node.js are:
limitations under the License.
"""

- simdutf, located at deps/simdutf, is licensed as follows:
- simdutf, located at deps/v8/third_party/simdutf, is licensed as follows:
"""
Copyright 2021 The simdutf authors

Expand Down
16 changes: 1 addition & 15 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -654,10 +654,6 @@ test-internet: all ## Run internet tests.
test-tick-processor: all ## Run tick processor tests.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) tick-processor

.PHONY: test-hash-seed
test-hash-seed: all ## Verifu that the hash seed used by V8 for hashing is random.
$(NODE) test/pummel/test-hash-seed.js

.PHONY: test-doc
test-doc: doc-only lint-md ## Build, lint, and verify the docs.
@if [ "$(shell $(node_use_openssl_and_icu))" != "true" ]; then \
Expand Down Expand Up @@ -751,8 +747,6 @@ test-v8: v8 ## Run the V8 test suite on deps/v8.
mjsunit cctest debugger inspector message preparser \
$(TAP_V8)
$(call convert_to_junit,$(TAP_V8_JSON))
$(info Testing hash seed)
$(MAKE) test-hash-seed

test-v8-intl: v8 ## Run the v8 test suite, intl tests.
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
Expand All @@ -768,7 +762,7 @@ test-v8-benchmarks: v8 ## Run the v8 test suite, benchmarks.
$(TAP_V8_BENCHMARKS)
$(call convert_to_junit,$(TAP_V8_BENCHMARKS_JSON))

test-v8-updates: ## Run the v8 test suite, updates.
test-v8-updates: all ## Run the v8 test suite, updates.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) v8-updates

test-v8-all: test-v8 test-v8-intl test-v8-benchmarks test-v8-updates ## Run the entire V8 test suite, including intl, benchmarks, and updates.
Expand Down Expand Up @@ -949,9 +943,6 @@ else
ifeq ($(findstring s390x,$(UNAME_M)),s390x)
DESTCPU ?= s390x
else
ifeq ($(findstring s390,$(UNAME_M)),s390)
DESTCPU ?= s390
else
ifeq ($(findstring OS/390,$(shell uname -s)),OS/390)
DESTCPU ?= s390x
else
Expand Down Expand Up @@ -985,7 +976,6 @@ endif
endif
endif
endif
endif
ifeq ($(DESTCPU),x64)
ARCH=x64
else
Expand All @@ -998,9 +988,6 @@ else
ifeq ($(DESTCPU),ppc64)
ARCH=ppc64
else
ifeq ($(DESTCPU),s390)
ARCH=s390
else
ifeq ($(DESTCPU),s390x)
ARCH=s390x
else
Expand All @@ -1018,7 +1005,6 @@ endif
endif
endif
endif
endif

# node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
# pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.
Expand Down
2 changes: 1 addition & 1 deletion benchmark/napi/function_args/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ void CallWithString(const FunctionCallbackInfo<Value>& args) {
assert(args.Length() == 1 && args[0]->IsString());
if (args.Length() == 1 && args[0]->IsString()) {
Local<String> str = args[0].As<String>();
const int32_t length = str->Utf8Length(args.GetIsolate()) + 1;
const size_t length = str->Utf8LengthV2(args.GetIsolate()) + 1;
char* buf = new char[length];
str->WriteUtf8(args.GetIsolate(), buf, length);
delete[] buf;
Expand Down
3 changes: 2 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.12',
'v8_embedder_string': '-node.10',

##### V8 defaults for Node.js #####

Expand Down Expand Up @@ -568,6 +568,7 @@
}],
[ 'node_shared=="true"', {
'cflags': [ '-fPIC' ],
'ldflags': [ '-fPIC' ],
}],
],
}],
Expand Down
7 changes: 0 additions & 7 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -640,12 +640,6 @@
default=None,
help='[Experimental] Enable V8 pointer compression (limits max heap to 4GB and breaks ABI compatibility)')

parser.add_argument('--disable-shared-readonly-heap',
action='store_true',
dest='disable_shared_ro_heap',
default=None,
help='Disable the shared read-only heap feature in V8')

parser.add_argument('--v8-options',
action='store',
dest='v8_options',
Expand Down Expand Up @@ -1720,7 +1714,6 @@ def configure_v8(o, configs):
o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0
o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
o['variables']['v8_enable_extensible_ro_snapshot'] = 0
o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0
o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform)
Expand Down
14 changes: 0 additions & 14 deletions deps/simdutf/BUILD.gn

This file was deleted.

13 changes: 0 additions & 13 deletions deps/simdutf/README.md

This file was deleted.

21 changes: 0 additions & 21 deletions deps/simdutf/simdutf.gyp

This file was deleted.

32 changes: 0 additions & 32 deletions deps/simdutf/unofficial.gni

This file was deleted.

7 changes: 6 additions & 1 deletion deps/v8/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# Enable Bzlmod for every Bazel command
common --enable_bzlmod

# Pass CC, CXX and PATH from the environment
build --action_env=CC
build --action_env=CXX
build --action_env=PATH
build --copt=-std=c++20

# Use Clang compiler
build:clang --action_env=BAZEL_COMPILER=clang
Expand All @@ -17,7 +21,8 @@ build:debug --compilation_mode=dbg
build:debug --config=v8_enable_debugging_features
build:debug --//:v8_enable_fast_mksnapshot
build:debug --//:v8_enable_backtrace
build:debug --//:v8_enable_handle_zapping
build:debug --//:v8_enable_local_handle_zapping
build:debug --//:v8_enable_global_handle_zapping

# v8_enable_debugging_features flags
build:v8_enable_debugging_features --//:v8_enable_verify_heap
Expand Down
2 changes: 2 additions & 0 deletions deps/v8/.clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
modernize-redundant-void-arg,
modernize-replace-random-shuffle,
modernize-shrink-to-fit,
modernize-type-traits,
# modernize-use-auto,
modernize-use-constraints,
modernize-use-bool-literals,
modernize-use-equals-default,
# modernize-use-equals-delete,
Expand Down
13 changes: 11 additions & 2 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,21 @@
/third_party/googletest/src/googletest/include/gtest/*
!/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
!/third_party/highway
/third_party/highway/src
/third_party/highway/src/*
!/third_party/highway/src/hwy
!/third_party/inspector_protocol
!/third_party/jsoncpp
/third_party/jsoncpp/source
!/third_party/llvm-libc
/third_party/llvm-libc/src
!/third_party/rapidhash-v8
!/third_party/re2
/third_party/re2/src
!/third_party/test262-harness
!/third_party/siphash
!/third_party/utf8-decoder
!/third_party/v8
!/third_party/valgrind
!/third_party/vtune
!/third_party/wasm-api
/tools/builtins-pgo/profiles/*
!/tools/builtins-pgo/profiles/.*
Expand All @@ -103,6 +110,7 @@
/tools/oom_dump/oom_dump
/tools/oom_dump/oom_dump.o
/tools/protoc_wrapper
/tools/rust
/tools/turbolizer/build
/tools/turbolizer/.rpt2_cache
/tools/turbolizer/deploy
Expand Down Expand Up @@ -145,3 +153,4 @@ bazel-v8
!/third_party/fp16
/third_party/fp16/src/*
!/third_party/fp16/src/include
!/third_party/simdutf
3 changes: 2 additions & 1 deletion deps/v8/.gn
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ no_check_targets = [
default_args = {
# Disable js dependencies like the closure compiler.
enable_js_protobuf = false

# Disable rust dependencies.
enable_rust = false
enable_rust = true
}

# These are the list of GN files that run exec_script. This whitelist exists
Expand Down
11 changes: 10 additions & 1 deletion deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ Alexander Botero-Lowry <alexbl@FreeBSD.org>
Alexander Karpinsky <homm86@gmail.com>
Alexander Neville <dark@volatile.bz>
Alexandre Vassalotti <avassalotti@gmail.com>
Alexey Pavlyutkin <alexey.pavlyutkin.community@gmail.com>
Alexey Pavlyutkin <alexey.pavlyutkin@syntacore.com>
Alexis Campailla <alexis@janeasystems.com>
Aliya Minimullina <a.minimullina@syntacore.com>
Allan Sandfeld Jensen <allan.jensen@qt.io>
Amos Lim <eui-sang.lim@samsung.com>
Andreas Anyuru <andreas.anyuru@gmail.com>
Expand Down Expand Up @@ -120,6 +121,7 @@ Dominic Farolini <domfarolino@gmail.com>
Douglas Crosher <dtc-v8@scieneer.com>
Dusan Milosavljevic <dusan.m.milosavljevic@gmail.com>
Eden Wang <nedenwang@tencent.com>
Edoardo Marangoni <edoardo@wasmer.io>
Elisha Hollander <just4now666666@gmail.com>
Eric Rannaud <eric.rannaud@gmail.com>
Erich Ocean <erich.ocean@me.com>
Expand Down Expand Up @@ -210,11 +212,13 @@ Maxim Mazurok <maxim@mazurok.com>
Maxim Mossienko <maxim.mossienko@gmail.com>
Md Hasibul Hasan <hasibulhasan873@gmail.com>
Meir Shpilraien <meir@redis.com>
Meng Tan <tannal2409@gmail.com>
Michael Lutz <michi@icosahedron.de>
Michael Mclaughlin <m8ch88l@gmail.com>
Michael Smith <mike@w3.org>
Michaël Zasso <mic.besace@gmail.com>
Mihir Shah <mihirshah.11204@gmail.com>
Mika Fischer <mika.fischer@zoopnet.de>
Mike Gilbert <floppymaster@gmail.com>
Mike Pennisi <mike@mikepennisi.com>
Mikhail Gusarov <dottedmag@dottedmag.net>
Expand Down Expand Up @@ -268,6 +272,7 @@ Sébastien Doeraene <sjrdoeraene@gmail.com>
Seo Sanghyeon <sanxiyn@gmail.com>
Shawn Anastasio <shawnanastasio@gmail.com>
Shawn Presser <shawnpresser@gmail.com>
Sho Miyamoto <me@shqld.dev>
Stefan Penner <stefan.penner@gmail.com>
Stefan Stojanovic <stefko.stojanovic@gmail.com>
Stephan Hartmann <stha09@googlemail.com>
Expand All @@ -290,6 +295,7 @@ Varun Varada <varuncvarada@gmail.com>
Victor Costan <costan@gmail.com>
Victor Polevoy <fx@thefx.co>
Vlad Burlik <vladbph@gmail.com>
Vladimir Kempik <vladimir.kempik@syntacore.com>
Vladimir Krivosheev <develar@gmail.com>
Vladimir Shutoff <vovan@shutoff.ru>
Wael Almattar <waelsy123@gmail.com>
Expand All @@ -303,6 +309,7 @@ Wiktor Garbacz <wiktor.garbacz@gmail.com>
Wouter Vermeiren <wouter.vermeiren@essensium.com>
Xiaofang Zou <zouxiaofang@iscas.ac.cn>
Xiaoyin Liu <xiaoyin.l@outlook.com>
Yagiz Nizipli <yagiz@nizipli.com>
Yanbo Li <lybvinci@gmail.com>
Yannic Bonenberger <contact@yannic-bonenberger.com>
Yi Wang <wangyi8848@gmail.com>
Expand All @@ -317,6 +324,7 @@ Yuxiang Cao <caoyxsh@outlook.com>
Zac Hansen <xaxxon@gmail.com>
Zeynep Cankara <zeynepcankara402@gmail.com>
Zhao Jiazhong <kyslie3100@gmail.com>
Zhao Qin <qzmiss@gmail.com>
Zhaojun Meng <zhaojun.meng@gmail.com>
Zheng Liu <i6122f@gmail.com>
Zhongping Wang <kewpie.w.zp@gmail.com>
Expand All @@ -325,3 +333,4 @@ Yang Xiang <xiangyangemail@gmail.com>
Kotaro Ohsugi <dec4m4rk@gmail.com>
Jing Peiyang <jingpeiyang@eswincomputing.com>
magic-akari <akari.ccino@gmail.com>
Ryuhei Shima <shimaryuhei@gmail.com>
Loading
Loading