Strip non-free ICC profile and fix test #5811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kept the picture instead of using some already included logo, because
|
|
@kapouer this seems to have conflicts landing against master. Could you rebase your branch and force push please |
|
Huuu.. i cleaned up these old forks and made another PR. |
JakubVanek
added a commit
to JakubVanek/zeroelabviewer_pkg
that referenced
this pull request
Sep 16, 2024
Currently, Zero eLab Viewer prints the following warning message during startup: > libpng warning: iCCP: known incorrect sRGB profile The CTU logo PNGs contain the IEC61966-2.1 color profile. This profile reportedly can cause problems [1] and is non-free [2]. To resolve the issue and stop the warning, this commit alters the images to remove the color profile. Visually, the images look the same in GIMP. The files were updated using the following command [3]: $ convert image.png +profile "icc" image.png [1]: https://github.com/pnggroup/libpng/blob/68d7ce8040a611e9166890e02ecc409a03d76c2e/png.c#L2372 [2]: google/cadvisor#915 [3]: nodejs/node#5811
JakubVanek
added a commit
to JakubVanek/zeroelabviewer_pkg
that referenced
this pull request
Sep 16, 2024
Currently, Zero eLab Viewer prints the following warning message during startup: > libpng warning: iCCP: known incorrect sRGB profile The CTU logo PNGs contain the IEC61966-2.1 color profile. This profile reportedly can cause problems [1] and is non-free [2]. To resolve the issue and stop the warning, this commit alters the images to remove the color profile. The images look the same in GIMP. The files were updated using the following command [3]: ``` $ convert image.png +profile "icc" image.png ``` [1]: https://github.com/pnggroup/libpng/blob/68d7ce8040a611e9166890e02ecc409a03d76c2e/png.c#L2372 [2]: google/cadvisor#915 [3]: nodejs/node#5811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5749
It might be a good idea to mention somewhere that when adding a picture into the project,
it is safer to remove potentially non-free profiles by doing: