-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
tools: add message on auto-fixing js lint issues in gh workflow #59128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/gh-workflow-lint-js-fix-message
Oct 5, 2025
Merged
tools: add message on auto-fixing js lint issues in gh workflow #59128
nodejs-github-bot
merged 1 commit into
nodejs:main
from
dario-piotrowicz:dario/gh-workflow-lint-js-fix-message
Oct 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
lpinca
approved these changes
Jul 20, 2025
d5ead24
to
203b072
Compare
marco-ippolito
approved these changes
Jul 21, 2025
jasnell
approved these changes
Jul 21, 2025
aduh95
reviewed
Jul 22, 2025
aduh95
reviewed
Jul 22, 2025
aduh95
reviewed
Sep 21, 2025
aduh95
reviewed
Sep 21, 2025
aduh95
reviewed
Sep 21, 2025
aduh95
reviewed
Sep 21, 2025
aduh95
approved these changes
Sep 25, 2025
3b9d0f1
to
da66e79
Compare
da66e79
to
e4b243c
Compare
aduh95
approved these changes
Oct 5, 2025
@aduh95 thanks a bunch for the approval! I was fixing one last small issue and double checking that everything works as intended 😄 |
Landed in 0c1fb98 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59128 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cpp formatting the github workflow prints a helpful message suggesting how to fix the issue:

I figured it could be nice to have the same for the js linting.
Before
After