Skip to content

Conversation

dario-piotrowicz
Copy link
Member

For cpp formatting the github workflow prints a helpful message suggesting how to fix the issue:
Screenshot at 2025-07-20 00-59-55

I figured it could be nice to have the same for the js linting.

Before

Screenshot at 2025-07-20 01-02-49

After

Screenshot at 2025-07-20 00-58-31

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 20, 2025
@dario-piotrowicz dario-piotrowicz changed the title tools: add message on auto-fixting js lint issues in gh workflow tools: add message on auto-fixing js lint issues in gh workflow Jul 21, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/gh-workflow-lint-js-fix-message branch from d5ead24 to 203b072 Compare July 21, 2025 10:34
@dario-piotrowicz dario-piotrowicz added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 21, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/gh-workflow-lint-js-fix-message branch from 3b9d0f1 to da66e79 Compare October 5, 2025 16:03
@dario-piotrowicz dario-piotrowicz force-pushed the dario/gh-workflow-lint-js-fix-message branch from da66e79 to e4b243c Compare October 5, 2025 16:21
@dario-piotrowicz
Copy link
Member Author

@aduh95 thanks a bunch for the approval! I was fixing one last small issue and double checking that everything works as intended 😄

@dario-piotrowicz dario-piotrowicz added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 0c1fb98 into nodejs:main Oct 5, 2025
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0c1fb98

@dario-piotrowicz dario-piotrowicz deleted the dario/gh-workflow-lint-js-fix-message branch October 5, 2025 18:11
targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #59128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants