Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode: update to 1.4.1 #5922

Closed
wants to merge 1 commit into from

Conversation

benjamingr
Copy link
Member

Affected core subsystem(s)

punycode

Description of change

Update punycode to the latest released version. This is mainly in order to reduce the maintenance burden. In #1246 a fix introducing new to errors was introduced and it has since been ported back to the punycode library.

This puts Node back in sync with the library itself so it can receive future fixes and updates directly.

Update punycode to the latest released version. This is mainly in
order to further reduce the maintenance burden. In
nodejs#1246 a fix introducing `new` to
errors was introduced and it has since been ported back to the
punycode library.

This puts Node back in sync with the library itself so it can receive
future fixes and updates directly.

PR-URL:
Reviewed-By:
Reviewed-By:
@cjihrig
Copy link
Contributor

cjihrig commented Mar 28, 2016

I think we've been down this path before and didn't update because there are no meaningful changes here. -1

@Fishrock123
Copy link
Contributor

@cjihrig I also seem to recall that.

@benjamingr
Copy link
Member Author

Oh, ok. I just noticed it wasn't updated - I think I'll just leave punycode alone, everything I try to do with it is poorly received and no one is complaining about the bad performance or completely un node-like code anyway.

@benjamingr benjamingr closed this Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants