doc: path.resolve ignores zero-length strings

[igorklopov]

path.resolve does not use cwd for zero-length strings as written in docs. Instead it just skips them when iterating.
https://github.com/nodejs/node/blob/master/lib/path.js#L187
https://github.com/nodejs/node/blob/master/lib/path.js#L1189

[benjamingr]

I get cwd for zero length strings. What you're seeing is what happens when you have a path.resolve with some zero length strings in it, the doc comment is about:

path.resolve("");

See in https://github.com/nodejs/node/blob/master/lib/path.js#L1183 , it sets it to the cwd before that continue.

Thanks for coming by and wanting to make a contribution to the docs :) This one is by design though.

[benjamingr]

Maybe it would be appropriate to change the text to "are all zero length strings" or something similar

[igorklopov]

In the beginning of resolve article one already reads "If after using all from paths still no absolute path is found, the current working directory is used as well". So, cwd is already mentioned. No need to say it twice. Especially for wierd case path.resolve('', '', ''). Recently there was a sentence about non-string arguments. 08085c4 . I think we should add a similar one about empty strings.

[benjamingr]

I'm +0 on this - not sure it helps clarify too much, but LGTM.

I want to know what other docs members think about these sort of changes @nodejs/documentation

[eljefedelrodeodeljefe]

LGTM though I am also not sure if clarifies it more, but largely because of the API itself. Maybe we could have an issue to rewrite this whole doc part.

[jasnell]

LGTM

[jasnell]

Landed in 4c234df

[MylesBorins]

It looks like this change is not applicable to v5.x or v4.x

There was originally copy that mentioned this that was removed in an edit