Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions lib/internal/util/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -1684,23 +1684,28 @@ function formatNumber(fn, number, numericSeparator) {
}
return fn(`${number}`, 'number');
}

const numberString = String(number);
const integer = MathTrunc(number);
const string = String(integer);

if (integer === number) {
if (!NumberIsFinite(number) || StringPrototypeIncludes(string, 'e')) {
return fn(string, 'number');
if (!NumberIsFinite(number) || StringPrototypeIncludes(numberString, 'e')) {
return fn(numberString, 'number');
}
return fn(`${addNumericSeparator(string)}`, 'number');
return fn(addNumericSeparator(numberString), 'number');
}
if (NumberIsNaN(number)) {
return fn(string, 'number');
return fn(numberString, 'number');
}

const decimalIndex = StringPrototypeIndexOf(numberString, '.');
const integerPart = StringPrototypeSlice(numberString, 0, decimalIndex);
const fractionalPart = StringPrototypeSlice(numberString, decimalIndex + 1);

return fn(`${
addNumericSeparator(string)
addNumericSeparator(integerPart)
}.${
addNumericSeparatorEnd(
StringPrototypeSlice(String(number), string.length + 1),
)
addNumericSeparatorEnd(fractionalPart)
}`, 'number');
}

Expand Down
21 changes: 21 additions & 0 deletions test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -3324,6 +3324,27 @@ assert.strictEqual(
util.inspect(-123456789.12345678, { numericSeparator: true }),
'-123_456_789.123_456_78'
);

// Regression test for https://github.com/nodejs/node/issues/59376
// numericSeparator should work correctly for negative fractional numbers
{
// Test the exact values from the GitHub issue
const values = [0.1234, -0.12, -0.123, -0.1234, -1.234];
assert.strictEqual(
util.inspect(values, { numericSeparator: true }),
'[ 0.123_4, -0.12, -0.123, -0.123_4, -1.234 ]'
);

// Test individual negative fractional numbers between -1 and 0
assert.strictEqual(
util.inspect(-0.1234, { numericSeparator: true }),
'-0.123_4'
);
assert.strictEqual(
util.inspect(-0.12345, { numericSeparator: true }),
'-0.123_45'
);
}
}

// Regression test for https://github.com/nodejs/node/issues/41244
Expand Down
Loading