Skip to content

wasi: fix clean target in test/wasi/Makefile #59576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

wasi: fix clean target in test/wasi/Makefile #59576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/wasi/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@ wasm/pthread.wasm : c/pthread.c
wasm/%.wasm : c/%.c
$(CC) $< $(CFLAGS) --target=$(TARGET) --sysroot=$(SYSROOT) -s -o $@

.PHONY clean:
.PHONY: clean
.NOTPARALLEL: clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this .NOTPARALLEL?

If the .NOTPARALLEL special target has prerequisites, then each of those prerequisites will be considered a target and all prerequisites of these targets will be run serially.

According to the doc, .NOTPARALLEL is only useful when the target in this list has prerequisites, and their prerequisites are run serially. clean has no prerequisites.

Copy link
Contributor Author

@aduh95 aduh95 Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe, I was following what I did 4 years ago in

node/Makefile

Lines 198 to 200 in 7232f09

.PHONY: clean
.NOTPARALLEL: clean
clean: ## Remove build artifacts.

The idea would be to be able to run make -j clean all and have the clean part be run serially before all and its prerequisites start, in parallel

clean:
rm -f $(OBJ)
Loading