Skip to content

Conversation

@joyeecheung
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (3b4f9b2) to head (c434441).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #59582    +/-   ##
========================================
  Coverage   89.84%   89.84%            
========================================
  Files         666      667     +1     
  Lines      195336   196260   +924     
  Branches    38357    38568   +211     
========================================
+ Hits       175493   176326   +833     
- Misses      12318    12367    +49     
- Partials     7525     7567    +42     

see 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung
Copy link
Member Author

Formatted the addon code and changed the test to use cwd: tmpdir.path for the SEA since the testing environment does not allow access to os.tmpdir().

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
Member Author

Forgot the skipIfSingleExecutableIsNotSupported() call, added.

@joyeecheung
Copy link
Member Author

Forgot to skip on ppc64le like what's done in #59563, added

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
Member Author

For some reason, this doesn't actually work on Linux arm64 - but only in the GitHub actions, and x64 Linux seems to work alright in GitHub actions, and in the Jenkins CI, both work alright.

[process 202296]: --- stderr ---
/home/runner/work/node/node/node/test/.tmp.4536/sea: symbol lookup error: /home/runner/work/node/node/node/test/.tmp.4536/hello.node: undefined symbol: napi_define_properties

[process 202296]: --- stdout ---

[process 202296]: status = 127, signal = null
/home/runner/work/node/node/node/test/common/child_process.js:98
    throw error;
    ^

Error: - process terminated with status 127, expected 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants