-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
benchmark: update num to n in dgram offset-length #59708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
+1 |
done |
@brunocroh can you make sure to update the spreadsheet with the PRs you did? Also, let's focus just on benchmarks that take more than 10 min (on compare.js) to conclude |
Yes, sure. Since I don’t have permission to edit the table, I just added comments with the PR URL. Regarding the duration, I’m trying to focus on the ones that take longer to execute. At the same time, I’m also updating the ones that don’t support the N flag because of the requirements in nodejs/performance#187. |
Landed in e4e86ea...6ce89d7 |
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #59708 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Replace the
num
config withn
to be compatible with then
CLI argument.Since this benchmark doesn’t take too long to run (about 40s), I didn’t change the config.
I ran the benchmarks for comparison, but I’m not sure if using len as [1, 512, 1024] would provide better coverage than [1, 64, 256, 1024]. What do you guys think?
If that makes sense to you, let me know, and I can update it to
[1, 512, 1024]
.This change reduces the execution time from 40s to 30s.
Here’s the output for both configs:
len: [1, 64, 256, 1024]
len: [1,512,1024]
Benchmark Machine Specifications: