Skip to content

[v22.x backport] lib: handle windows reserved device names on UNC #59831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v22.x backport] lib: handle windows reserved device names on UNC #59831

wants to merge 2 commits into from

Conversation

RafaelGSS
Copy link
Member

huseyinacacak-janea and others added 2 commits September 9, 2025 17:16
@huseyinacacak-janea @RafaelGSS
path,win: fix bug in resolve and normalize
4b94984 
Fixes: nodejs#54025
PR-URL: nodejs#55623
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS
lib: handle windows reserved device names on UNC
b6033a0 
We have found that UNC paths weren't covered
when .join/.normalize windows reserved device
names (COM1, LPT1).

PR-URL: nodejs#59286
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/path

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 9, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69250/

richardlau pushed a commit that referenced this pull request Sep 17, 2025
@huseyinacacak-janea @richardlau
path,win: fix bug in resolve and normalize
9cc89f5 
Fixes: #54025
PR-URL: #55623
Backport-PR-URL: #59831
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 17, 2025
@RafaelGSS @richardlau
lib: handle windows reserved device names on UNC
0b631bb 
We have found that UNC paths weren't covered
when .join/.normalize windows reserved device
names (COM1, LPT1).

PR-URL: #59286
Backport-PR-URL: #59831
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau
Copy link
Member

Landed in 98e399b...0b631bb

@richardlau richardlau closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @nodejs-github-bot @richardlau @StefanStojanovic @huseyinacacak-janea