-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
win,tools: Add description to signature #59877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
martincostello:sign-tool-description
Oct 3, 2025
Merged
win,tools: Add description to signature #59877
nodejs-github-bot
merged 1 commit into
nodejs:main
from
martincostello:sign-tool-description
Oct 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 13, 2025
lpinca
approved these changes
Sep 13, 2025
daeyeon
approved these changes
Sep 14, 2025
When signing files for Windows, add "Node.js" as the description.
77cd3b9
to
2c0bf67
Compare
StefanStojanovic
approved these changes
Sep 17, 2025
Test failures look like flaky tests on macOS. Can someone re-run and merge please? |
Landed in 85b0e06 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
When signing files for Windows, add "Node.js" as the description. PR-URL: #59877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lts-watch-v20.x
PRs that may need to be released in v20.x
lts-watch-v22.x
PRs that may need to be released in v22.x
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When signing files for Windows, add "Node.js" as the description.
This should cause the string highlighted in the UAC elevation prompt screenshot below to be replaced with the string specified as the description.