Skip to content

Conversation

martincostello
Copy link
Contributor

When signing files for Windows, add "Node.js" as the description.

This should cause the string highlighted in the UAC elevation prompt screenshot below to be replaced with the string specified as the description.

image

@Copilot Copilot AI review requested due to automatic review settings September 13, 2025 09:43
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Sep 13, 2025
Copilot

This comment was marked as spam.

When signing files for Windows, add "Node.js" as the description.
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2025
@nodejs-github-bot
Copy link
Collaborator

@martincostello
Copy link
Contributor Author

Test failures look like flaky tests on macOS.

Can someone re-run and merge please?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Oct 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit 85b0e06 into nodejs:main Oct 3, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 85b0e06

@martincostello martincostello deleted the sign-tool-description branch October 3, 2025 23:23
targos pushed a commit that referenced this pull request Oct 6, 2025
When signing files for Windows, add "Node.js" as the description.

PR-URL: #59877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants