Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 14, 2025

Makes a number of updates in the quic impl

also, updates the ngtcp2 dependency and brings in the ngtcp2 example server and client to prepare to use it for building tests. DRAFT for now because I'll need to test building the examples on all the architectures.

I removed the test executables as it'll definitely require more refinement in the build to work on all the different architectures. Will move it to a separate PR

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

@jasnell jasnell marked this pull request as draft September 14, 2025 02:42
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 14, 2025
@jasnell jasnell force-pushed the jasnell/quic-iterations branch from 5005323 to 2b9558f Compare September 14, 2025 02:51
@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell force-pushed the jasnell/quic-iterations branch from 2b9558f to fa74543 Compare September 14, 2025 03:24
@jasnell jasnell marked this pull request as ready for review September 14, 2025 03:25
@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell changed the title src: cleanup quic TransportParams class quic: multiple quic updates, update ngtcp2 dependency Sep 14, 2025

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@jasnell
Copy link
Member Author

jasnell commented Sep 19, 2025

The test failures are not flakes. I'll need to fix those up this weekend

@jasnell jasnell force-pushed the jasnell/quic-iterations branch from fa74543 to c31a71a Compare September 20, 2025 00:58
@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell force-pushed the jasnell/quic-iterations branch from c31a71a to a788df1 Compare September 20, 2025 01:08
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3625623 into nodejs:main Sep 20, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3625623

@targos targos added dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 23, 2025
@targos
Copy link
Member

targos commented Sep 23, 2025

#59342 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants