Skip to content

sqlite: create authorization api #59928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

sqlite: create authorization api #59928

wants to merge 18 commits into from
+694 −0

Conversation

araujogui
Copy link
Member

Fixes #59916

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 18, 2025
geeksilva97
geeksilva97 reviewed Sep 18, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (97e55f8) to head (0f4816f).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.07% 8 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59928      +/-   ##
==========================================
+ Coverage   88.27%   88.46%   +0.18%     
==========================================
  Files         703      703              
  Lines      207333   207653     +320     
  Branches    39875    40031     +156     
==========================================
+ Hits       183028   183691     +663     
+ Misses      16263    15942     -321     
+ Partials     8042     8020      -22
Files with missing lines Coverage Δ
src/node_sqlite.h 80.39% <ø> (ø)
src/node_sqlite.cc 80.15% <88.07%> (+0.54%) ⬆️

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax
addaleax requested changes Sep 18, 2025
View reviewed changes
addaleax
addaleax approved these changes Sep 23, 2025
View reviewed changes
addaleax
addaleax reviewed Sep 24, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 24, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69378/

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69387/

addaleax
addaleax reviewed Sep 26, 2025
View reviewed changes
@araujogui
Copy link
Member Author

@addaleax @geeksilva97 are we good to merge?

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69472/

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 1, 2025
@addaleax
Copy link
Member

addaleax commented Oct 1, 2025

Landed in b217051

addaleax pushed a commit that referenced this pull request Oct 1, 2025
@araujogui @addaleax
sqlite: create authorization api
b217051 
PR-URL: #59928
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@addaleax addaleax closed this Oct 1, 2025
@cjihrig cjihrig mentioned this pull request Oct 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig left review comments

@geeksilva97 geeksilva97 geeksilva97 approved these changes

+1 more reviewer

@Renegade334 Renegade334 Renegade334 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite: expose authorization API
6 participants
@araujogui @nodejs-github-bot @addaleax @cjihrig @Renegade334 @geeksilva97