deps: add ngtcp2 test binaries #59946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
the
quic
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
3 times, most recently
from
dab25f9 to
5c6f34a
Compare
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation.
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
4 times, most recently
from
e487547 to
0e4cf64
Compare
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
0e4cf64 to
d4ac0e2
Compare
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59946 +/- ##
==========================================
+ Coverage 88.41% 88.44% +0.02%
==========================================
Files 703 703
Lines 207398 207401 +3
Branches 39987 39992 +5
==========================================
+ Hits 183374 183438 +64
+ Misses 15995 15933 -62
- Partials 8029 8030 +1 🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
d4ac0e2 to
285bcf1
Compare
jasnell
force-pushed
the
jasnell/add-ngtcp2-test-binaries
branch
from
285bcf1 to
8d093b4
Compare
anonrig
approved these changes
Sep 27, 2025
jasnell
added
the
commit-queue
jasnell
added
the
commit-queue-rebase
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/59946 ✔ Done loading data for nodejs/node/pull/59946 ----------------------------------- PR info ------------------------------------ Title deps: add ngtcp2 test binaries (#59946) Author James M Snell <jasnell@gmail.com> (@jasnell) Branch jasnell:jasnell/add-ngtcp2-test-binaries -> nodejs:main Labels build, http2, needs-ci, quic, commit-queue-rebase Commits 2 - deps: add ngtcp2 test binaries - tests: start adding quic test server utilities Committers 1 - James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 20 Sep 2025 14:15:38 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/59946#pullrequestreview-3274990209 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-09-20T17:08:24Z: https://ci.nodejs.org/job/node-test-pull-request/69302/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - tests: start adding quic test server utilities - Querying data for job/node-test-pull-request/69302/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18062739445 |
nodejs-github-bot
added
the
commit-queue-failed
jasnell
added a commit
that referenced
this pull request
Sep 27, 2025
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation. PR-URL: #59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
jasnell
added a commit
that referenced
this pull request
Sep 27, 2025
PR-URL: #59946 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Member
Author
|
Landed in 2e5c8df...cff138c |
targos
added
the
dont-land-on-v24.x
Member
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to add the ngtcp2 client and server samples so that we can use them in CI to test our QUIC implementation.
The sample server/client from ngtcp2 does not currently build on AIX or Windows but that should be fine. The tests against these won't be the only tests we do, they are intended only to be able to prove that our implementation can interop with an existing other implementations.