tools: use dependabot cooldown and move tools/doc #59978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
aduh95
reviewed
Sep 23, 2025
.github/dependabot.yml
Outdated
Comment on lines
10
to
12
| - semver-major: 5 | ||
| - semver-minor: 5 | ||
| - semver-patch: 5 |
There was a problem hiding this comment.
Looking at the docs, those are not listed as actual options. I think you meant that:
Suggested change
| - semver-major: 5 | |
| - semver-minor: 5 | |
| - semver-patch: 5 | |
| - default-days: 5 |
.github/dependabot.yml
Outdated
Comment on lines
23
to
25
| - semver-major: 5 | ||
| - semver-minor: 5 | ||
| - semver-patch: 5 |
There was a problem hiding this comment.
Suggested change
| - semver-major: 5 | |
| - semver-minor: 5 | |
| - semver-patch: 5 | |
| - default-days: 5 |
.github/dependabot.yml
Outdated
Comment on lines
40
to
42
| - semver-major: 5 | ||
| - semver-minor: 5 | ||
| - semver-patch: 5 |
There was a problem hiding this comment.
Suggested change
| - semver-major: 5 | |
| - semver-minor: 5 | |
| - semver-patch: 5 | |
| - default-days: 5 |
.github/dependabot.yml
Outdated
Comment on lines
57
to
59
| - semver-major: 5 | ||
| - semver-minor: 5 | ||
| - semver-patch: 5 |
There was a problem hiding this comment.
Suggested change
| - semver-major: 5 | |
| - semver-minor: 5 | |
| - semver-patch: 5 | |
| - default-days: 5 |
|
They are listed - I forgot to include the |
aduh95
reviewed
Sep 23, 2025
Comment on lines
+10
to
+12
| - semver-major-days: 5 | ||
| - semver-minor-days: 5 | ||
| - semver-patch-days: 5 |
There was a problem hiding this comment.
Why not go with my previous suggestion?
Suggested change
| - semver-major-days: 5 | |
| - semver-minor-days: 5 | |
| - semver-patch-days: 5 | |
| - default-days: 5 |
There was a problem hiding this comment.
Just personal preference, I like things more explicit, it makes change clearer and easier.
UlisesGascon
approved these changes
Sep 29, 2025
RafaelGSS
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59978 ✔ Done loading data for nodejs/node/pull/59978 ----------------------------------- PR info ------------------------------------ Title tools: use dependabot cooldown and move tools/doc (#59978) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:add-cooldown-dependabot -> nodejs:main Labels meta, author ready Commits 3 - tools: use dependabot cooldown and move tools/doc - fixup! tools: use dependabot cooldown and move tools/doc - fixup! fixup! tools: use dependabot cooldown and move tools/doc Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/59978 Refs: https://github.com/nodejs/node/issues/59911 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59978 Refs: https://github.com/nodejs/node/issues/59911 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 22 Sep 2025 22:21:05 GMT ✔ Approvals: 1 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/59978#pullrequestreview-3281597871 ✘ This PR needs to wait 1 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18109626886 |
RafaelGSS
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59978 ✔ Done loading data for nodejs/node/pull/59978 ----------------------------------- PR info ------------------------------------ Title tools: use dependabot cooldown and move tools/doc (#59978) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:add-cooldown-dependabot -> nodejs:main Labels meta, author ready Commits 3 - tools: use dependabot cooldown and move tools/doc - fixup! tools: use dependabot cooldown and move tools/doc - fixup! fixup! tools: use dependabot cooldown and move tools/doc Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/59978 Refs: https://github.com/nodejs/node/issues/59911 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59978 Refs: https://github.com/nodejs/node/issues/59911 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 22 Sep 2025 22:21:05 GMT ✔ Approvals: 1 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/59978#pullrequestreview-3281597871 ✘ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18111664340 |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1d49478 |
|
Config seems invalid: https://github.com/nodejs/node/runs/51603058583 |
Will check as soon as I get back to the computer. |
|
I have pushed a potential fix for it on my local fork, but I'm not sure how to test it. How did you get the runs list @targos? Ref: RafaelGSS@3d5cf5b |
|
It's in the GitHub checks of the commit on |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #59911
cc: @nodejs/security-wg