Skip to content

build: test on Python 3.14 #59983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: test on Python 3.14 #59983

wants to merge 1 commit into from
+29 −13

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 23, 2025

@cclauss cclauss added notable-change PRs with changes that should be highlighted in changelogs. python PRs and issues that require attention from people who are familiar with Python. labels Sep 23, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 23, 2025 •
edited by cclauss
Loading

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
  • @nodejs/python
  • @nodejs/platform-windows

@github-actions GitHub Actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @cclauss.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Sep 23, 2025
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Sep 23, 2025
@cclauss cclauss mentioned this pull request Sep 23, 2025
Merged
@cclauss cclauss changed the title chore(ci): Test on Python 3.14 release candidate 3 build: Test on Python 3.14 release candidate 3 Sep 23, 2025
@cclauss cclauss changed the title build: Test on Python 3.14 release candidate 3 build: test on Python 3.14 release candidate 3 Sep 23, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (4396cf2) to head (109d743).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59983      +/-   ##
==========================================
- Coverage   88.46%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207368   207368              
  Branches    39983    39980       -3     
==========================================
- Hits       183438   183427      -11     
+ Misses      15933    15931       -2     
- Partials     7997     8010      +13

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cclauss cclauss requested review from marco-ippolito and panva and removed request for marco-ippolito September 25, 2025 06:43
@panva panva removed their request for review September 25, 2025 06:46
@cclauss cclauss mentioned this pull request Sep 25, 2025
Merged
@cclauss
Copy link
Contributor Author

cclauss commented Oct 7, 2025

Python 3.14 (the π version) was released today.
https://www.python.org/downloads/release/python-3140/
https://github.com/actions/python-versions/releases

@cclauss cclauss changed the title build: test on Python 3.14 release candidate 3 build: test on Python 3.14 Oct 7, 2025
marco-ippolito
marco-ippolito reviewed Oct 7, 2025
View reviewed changes
.github/workflows/build-tarball.yml
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: ${{ env.PYTHON_VERSION }}
allow-prereleases: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we dont need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually just leave them in place so we can test Python 3.15, etc.

marco-ippolito
marco-ippolito approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI

StefanStojanovic
StefanStojanovic approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@cclauss
Copy link
Contributor Author

cclauss commented Oct 10, 2025

Can someone please merge this one? I do not understand the hieroglyphics of the regex error message.

sxa
sxa approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@sxa sxa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I came here to raise a PR to do this (Fedora 43 will have 3.14 by default, and I've configured and run a build with it without problems.

@sxa
Copy link
Member

sxa commented Oct 10, 2025 •
edited
Loading

LGTM with a green CI

@cclauss Has it had a CI run?

[EDIT: I've kicked one off - I don't expect any issues though 🤞🏻 ]

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69655/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sxa sxa sxa approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cclauss @nodejs-github-bot @sxa @StefanStojanovic @marco-ippolito @aduh95