Skip to content

deps: update ada to 3.2.9 #59987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
+17 −7
Merged

deps: update ada to 3.2.9 #59987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions deps/ada/ada.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2025-07-27 12:29:50 -0400. Do not edit! */
/* auto-generated on 2025-09-22 20:51:08 -0400. Do not edit! */
/* begin file src/ada.cpp */
#include "ada.h"
/* begin file src/checkers.cpp */
Expand Down Expand Up @@ -15841,7 +15841,11 @@ tl::expected<std::string, errors> url_pattern_init::process_search(
if (value.starts_with("?")) {
value.remove_prefix(1);
}
ADA_ASSERT_TRUE(!value.starts_with("?"));
// We cannot assert that the value is no longer starting with a single
// question mark because technically it can start. The question is whether or
// not we should remove the first question mark. Ref:
// https://github.com/ada-url/ada/pull/992 The spec is not clear on this.

// If type is "pattern" then return strippedValue.
if (type == process_type::pattern) {
return std::string(value);
Expand Down Expand Up @@ -16282,7 +16286,10 @@ tl::expected<std::string, errors> canonicalize_search(std::string_view input) {
url->set_search(input);
if (url->has_search()) {
const auto search = url->get_search();
return std::string(search.substr(1));
if (!search.empty()) {
return std::string(search.substr(1));
}
return "";
}
return tl::unexpected(errors::type_error);
}
Expand All @@ -16302,7 +16309,10 @@ tl::expected<std::string, errors> canonicalize_hash(std::string_view input) {
// Return dummyURL's fragment.
if (url->has_hash()) {
const auto hash = url->get_hash();
return std::string(hash.substr(1));
if (!hash.empty()) {
return std::string(hash.substr(1));
}
return "";
}
return tl::unexpected(errors::type_error);
}
Expand Down
6 changes: 3 additions & 3 deletions deps/ada/ada.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* auto-generated on 2025-07-27 12:29:50 -0400. Do not edit! */
/* auto-generated on 2025-09-22 20:51:08 -0400. Do not edit! */
/* begin file include/ada.h */
/**
* @file ada.h
Expand Down Expand Up @@ -10515,14 +10515,14 @@ constructor_string_parser<regex_provider>::parse(std::string_view input) {
#ifndef ADA_ADA_VERSION_H
#define ADA_ADA_VERSION_H

#define ADA_VERSION "3.2.7"
#define ADA_VERSION "3.2.9"

namespace ada {

enum {
ADA_VERSION_MAJOR = 3,
ADA_VERSION_MINOR = 2,
ADA_VERSION_REVISION = 7,
ADA_VERSION_REVISION = 9,
};

} // namespace ada
Expand Down
Loading