-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
test: mark test-web-locks skip on IBM i #59996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
sravani1510:ibmi-mark-test-web-locks-skip
Oct 1, 2025
Merged
test: mark test-web-locks skip on IBM i #59996
nodejs-github-bot
merged 1 commit into
nodejs:main
from
sravani1510:ibmi-mark-test-web-locks-skip
Oct 1, 2025
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Sep 24, 2025
abmusse
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59996 +/- ##
==========================================
- Coverage 88.44% 88.43% -0.02%
==========================================
Files 703 703
Lines 207532 207532
Branches 40007 40012 +5
==========================================
- Hits 183562 183523 -39
- Misses 15953 16002 +49
+ Partials 8017 8007 -10 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 24, 2025
Landed in c08164d |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59996 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Abdirahim Musse <abdirahim.musse@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the test-weblocks test it check the rss memory before and after but on IBM i this is always set to 0 from libuv
Reference:
node/src/node_process_methods.cc
Lines 229 to 233 in d2ff9da
libuv/libuv@8813dca
So, this test case can be skipped for now