Skip to content

src: remove AnalyzeTemporaryDtors option from .clang-tidy #60008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: remove AnalyzeTemporaryDtors option from .clang-tidy #60008

wants to merge 1 commit into from
+0 −1

Conversation

iknoom
Copy link
Contributor

@iknoom iknoom commented Sep 25, 2025 •
edited
Loading

This PR removes AnalyzeTemporaryDtors option from .clang-tidy. This option was deprecated since clang-tidy 16 and removed in clang-tidy 18.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 25, 2025
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69366/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69374/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69384/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69392/

gurgunday
gurgunday approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69577/

addaleax pushed a commit that referenced this pull request Oct 6, 2025
@iknoom @addaleax
src: remove AnalyzeTemporaryDtors option from .clang-tidy
81b7119 
PR-URL: #60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax
Copy link
Member

addaleax commented Oct 6, 2025

Landed in 81b7119

@addaleax addaleax closed this Oct 6, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
@iknoom @targos
src: remove AnalyzeTemporaryDtors option from .clang-tidy
5f9ff60 
PR-URL: #60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iknoom @nodejs-github-bot @addaleax @lpinca @anonrig @gurgunday