test: replace diagnostics_channel stackframe in output snapshots #60024
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
cjihrig
reviewed
Sep 26, 2025
legendecas
force-pushed
the
source-map-snapshot
branch
from
ab1b947 to
3e2795c
Compare
cjihrig
approved these changes
Sep 26, 2025
legendecas
force-pushed
the
source-map-snapshot
branch
from
3e2795c to
412d7df
Compare
|
Simplied the merged regex. |
cjihrig
approved these changes
Sep 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60024 +/- ##
==========================================
- Coverage 88.49% 88.46% -0.03%
==========================================
Files 703 703
Lines 207529 207546 +17
Branches 40011 40015 +4
==========================================
- Hits 183643 183609 -34
- Misses 15885 15938 +53
+ Partials 8001 7999 -2 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 26, 2025
github-actions
bot
removed
the
request-ci
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ffb25b8 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60024 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevent changes in
lib/diagnostics_channel.jsimpact test output snapshots.