-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
process: fix default env
for process.execve
#60029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `env` parameter for `process.execve` is documented to default to `process.env`.
cc @nodejs/process |
cjihrig
approved these changes
Sep 26, 2025
targos
approved these changes
Sep 26, 2025
lpinca
approved these changes
Sep 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60029 +/- ##
==========================================
- Coverage 88.47% 88.47% -0.01%
==========================================
Files 703 703
Lines 207546 207544 -2
Branches 40006 40011 +5
==========================================
- Hits 183631 183615 -16
- Misses 15907 15909 +2
- Partials 8008 8020 +12
🚀 New features to boost your workflow:
|
gurgunday
approved these changes
Oct 1, 2025
Landed in b8ea0e8 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
The `env` parameter for `process.execve` is documented to default to `process.env`. PR-URL: #60029 Refs: nodejs/build#4156 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
env
parameter forprocess.execve
is documented to default toprocess.env
.Refs: nodejs/build#4156 (comment)
process.execve
is documented to take an optionalenv
parameter that is supposed to default toprocess.env
:node/doc/api/process.md
Lines 1694 to 1708 in 2e5c8df
When we attempted to build a
sharedlibs_*
CI with clang we found thatparallel/test-process-execve-no-args
fails becauseprocess.execve
is not passing onprocess.env
to the new process. We didn't notice before when using gcc because on Ubuntu (and other Debian-derived Linux distributions) gcc by default links with--as-needed
but clang (and gcc on other Linux distributions) does not.No new test is added, this will unblock the work being done in nodejs/build#4156 and once that is complete regressions will be caught there by the existing
parallel/test-process-execve-no-args
.