src: update cares_wrap to use DictionaryTemplates #60033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/dns-use-dictionarytemplate
branch
from
127af14 to
3be0a50
Compare
addaleax
approved these changes
Sep 27, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/dns-use-dictionarytemplate
branch
from
3be0a50 to
a4cca1d
Compare
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src: update cares_wrap to use DictionaryTemplates ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/18064805920 |
addaleax
approved these changes
Sep 27, 2025
jasnell
removed
the
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e6cd8a2 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60033 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cares_wrap to use DictionaryTemplates