-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
console,util: improve array inspection performance #60037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BridgeAR
wants to merge
1
commit into
nodejs:main
from
BridgeAR:BridgeAR/2025-09-27-improve-array-inspection-performance
Closed
console,util: improve array inspection performance #60037
BridgeAR
wants to merge
1
commit into
nodejs:main
from
BridgeAR:BridgeAR/2025-09-27-improve-array-inspection-performance
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to do the own property check, since the descriptor is needed right afterwards anyway.
addaleax
approved these changes
Sep 27, 2025
jasnell
approved these changes
Sep 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60037 +/- ##
==========================================
+ Coverage 88.28% 88.47% +0.19%
==========================================
Files 702 703 +1
Lines 206995 207547 +552
Branches 39833 40009 +176
==========================================
+ Hits 182740 183633 +893
+ Misses 16265 15903 -362
- Partials 7990 8011 +21
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Sep 28, 2025
ljharb
approved these changes
Sep 28, 2025
gurgunday
approved these changes
Sep 29, 2025
addaleax
pushed a commit
that referenced
this pull request
Sep 30, 2025
There is no need to do the own property check, since the descriptor is needed right afterwards anyway. PR-URL: #60037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
Landed in c2536ad |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
There is no need to do the own property check, since the descriptor is needed right afterwards anyway. PR-URL: #60037 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
console
Issues and PRs related to the console subsystem.
needs-ci
PRs that need a full CI run.
performance
Issues and PRs related to the performance of Node.js.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to do the own property check, since the descriptor is needed right afterwards anyway.