src: correct the error handling in StatementExecutionHelper #60040
+100
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/correct-error-handling-sqlite
branch
from
ca54aac to
515711d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Sep 27, 2025
jasnell
force-pushed
the
jasnell/correct-error-handling-sqlite
branch
from
515711d to
7b69c4f
Compare
geeksilva97
approved these changes
Sep 28, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Sep 28, 2025
addaleax
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
@jasnell Can you rebase this against main? |
addaleax
removed
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
Error handling logic was flawed in StatementExecutionHelper methods.
jasnell
force-pushed
the
jasnell/correct-error-handling-sqlite
branch
from
7b69c4f to
7c1aac3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added a commit
that referenced
this pull request
Oct 4, 2025
Error handling logic was flawed in StatementExecutionHelper methods. PR-URL: #60040 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
|
Landed in 2869c12 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
Error handling logic was flawed in StatementExecutionHelper methods. PR-URL: #60040 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling logic was flawed in StatementExecutionHelper methods.
When
IsNothing()is true orToLocal()fails, return an emptyMaybeLocalrather than creating an object or returning undefined.Also, avoid use of
ToLocalChecked/cc @0hmX ... just fyi