Skip to content

src: avoid unnecessary string -> char* -> string round trips #60055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: avoid unnecessary string -> char* -> string round trips #60055

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

In these places we can just generate std::string directly, so there's no need to convert to an intermediate C string.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2025
@addaleax
src: avoid unnecessary string -> char* -> string round trips
327d5d3 
In these places we can just generate `std::string` directly, so
there's no need to convert to an intermediate C string.
@addaleax addaleax force-pushed the to-string-direct-not-via-cstr branch from 132bc95 to 327d5d3 Compare September 28, 2025 12:47
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.47%. Comparing base (c6316f9) to head (327d5d3).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60055      +/-   ##
==========================================
+ Coverage   88.45%   88.47%   +0.01%     
==========================================
  Files         703      703              
  Lines      207546   207544       -2     
  Branches    40011    40004       -7     
==========================================
+ Hits       183591   183619      +28     
+ Misses      15949    15904      -45     
- Partials     8006     8021      +15
Files with missing lines Coverage Δ
src/inspector/protocol_helper.h 100.00% <100.00%> (ø)
src/node_blob.cc 75.48% <100.00%> (-0.69%) ⬇️
src/node_contextify.cc 81.53% <100.00%> (ø)
src/node_errors.h 87.50% <100.00%> (ø)
src/node_messaging.cc 81.79% <100.00%> (ø)
src/quic/defs.h 67.74% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69421/

addaleax added a commit that referenced this pull request Sep 30, 2025
@addaleax
src: avoid unnecessary string -> char* -> string round trips
77cf2ef 
In these places we can just generate `std::string` directly, so
there's no need to convert to an intermediate C string.

PR-URL: #60055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@addaleax
Copy link
Member Author

Landed in 77cf2ef

@addaleax addaleax closed this Sep 30, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
@addaleax @targos
src: avoid unnecessary string -> char* -> string round trips
eb99eec 
In these places we can just generate `std::string` directly, so
there's no need to convert to an intermediate C string.

PR-URL: #60055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @lpinca @legendecas