src: remove unnecessary std::string error messages
#60057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
If we can just use the classic `THROW_...()` methods directly, without needing to allocate an `std::string` for the message/format parameter, let's just do so.
addaleax
force-pushed
the
no-constant-std-string-format-arg-for-throw
branch
from
5d554db to
1440e19
Compare
jasnell
approved these changes
Sep 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60057 +/- ##
=======================================
Coverage 88.45% 88.46%
=======================================
Files 703 703
Lines 207546 207526 -20
Branches 40011 40005 -6
=======================================
- Hits 183591 183578 -13
+ Misses 15949 15936 -13
- Partials 8006 8012 +6
🚀 New features to boost your workflow:
|
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
Sep 28, 2025
legendecas
approved these changes
Sep 29, 2025
addaleax
added a commit
that referenced
this pull request
Sep 30, 2025
If we can just use the classic `THROW_...()` methods directly, without needing to allocate an `std::string` for the message/format parameter, let's just do so. PR-URL: #60057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in 2e2f4cd |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
If we can just use the classic `THROW_...()` methods directly, without needing to allocate an `std::string` for the message/format parameter, let's just do so. PR-URL: #60057 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can just use the classic
THROW_...()methods directly, without needing to allocate anstd::stringfor the message/format parameter, let's just do so.