Skip to content

src: allow std::string_view arguments to SPrintF() and friends #60058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: allow std::string_view arguments to SPrintF() and friends #60058

wants to merge 1 commit into from
+44 −32

Conversation

addaleax
Copy link
Member

Modernize the code so there is no need to work with raw C strings anymore.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2025
@addaleax addaleax force-pushed the sprintf-string-view-format-arg branch from 84646ef to 88a83f1 Compare September 28, 2025 12:44
@addaleax
src: allow std::string_view arguments to SPrintF() and friends
5a68e33 
Modernize the code so there is no need to work with raw C strings
anymore.
@addaleax addaleax force-pushed the sprintf-string-view-format-arg branch from 88a83f1 to 5a68e33 Compare September 28, 2025 12:48
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.45%. Comparing base (c6316f9) to head (5a68e33).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/debug_utils-inl.h 54.16% 5 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60058      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207546   207710     +164     
  Branches    40011    40012       +1     
==========================================
+ Hits       183591   183729     +138     
- Misses      15949    15973      +24     
- Partials     8006     8008       +2
Files with missing lines Coverage Δ
src/debug_utils.h 80.00% <ø> (ø)
src/node_errors.h 87.17% <100.00%> (-0.33%) ⬇️
src/debug_utils-inl.h 83.78% <54.16%> (-2.07%) ⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69419/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69430/

addaleax added a commit that referenced this pull request Sep 30, 2025
@addaleax
src: allow std::string_view arguments to SPrintF() and friends
3b0b6b9 
Modernize the code so there is no need to work with raw C strings
anymore.

PR-URL: #60058
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@addaleax
Copy link
Member Author

Landed in 3b0b6b9

@addaleax addaleax closed this Sep 30, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
@addaleax @targos
src: allow std::string_view arguments to SPrintF() and friends
354026d 
Modernize the code so there is no need to work with raw C strings
anymore.

PR-URL: #60058
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @jasnell @legendecas @juanarbol