test: mark sea tests flaky on macOS x64 #60068
Merged
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
test
cjihrig
approved these changes
Sep 29, 2025
targos
approved these changes
Sep 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60068 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 703 703
Lines 207546 207546
Branches 40011 40008 -3
==========================================
- Hits 183591 183580 -11
- Misses 15949 15959 +10
- Partials 8006 8007 +1 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Sep 29, 2025
RafaelGSS
approved these changes
Sep 29, 2025
RafaelGSS
added
author ready
|
Fast-track has been requested by @BridgeAR. Please 👍 to approve. |
addaleax
approved these changes
Sep 30, 2025
I went for flaky as, while they are failing 100% of the time on macOS 15 x64, they are generally passing on osx13 x64 and I don't think the Python test runner can make the distinction via the |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f304bc2 |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60068 Refs: #59553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #59553
These tests are occasionally failing in the CI on osx13-x64, but appear to be always failing on macos15-x64 and blocking anything from landing that requires a full CI.