Skip to content

module: use sync cjs when importing cts #60072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

module: use sync cjs when importing cts #60072

merged 1 commit into from
Oct 2, 2025

Conversation

marco-ippolito
Copy link
Member

Fixes: #59963

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 30, 2025
@marco-ippolito marco-ippolito changed the title module: use sync cjs loader with cts module: use sync cjs when importing cts Sep 30, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (c6316f9) to head (b4654bc).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60072   +/-   ##
=======================================
  Coverage   88.45%   88.46%           
=======================================
  Files         703      703           
  Lines      207546   207548    +2     
  Branches    40011    40004    -7     
=======================================
+ Hits       183591   183597    +6     
+ Misses      15949    15944    -5     
- Partials     8006     8007    +1
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 96.15% <100.00%> (+<0.01%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69458/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69461/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69460/

@marco-ippolito
Copy link
Member Author

I accidentally pressed retry in the CI

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69466/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69485/

@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. strip-types Issues or PRs related to strip-types support labels Oct 1, 2025
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 69144e9 into nodejs:main Oct 2, 2025
68 of 69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 69144e9

targos pushed a commit that referenced this pull request Oct 6, 2025
@marco-ippolito @targos
module: use sync cjs when importing cts
dbeee55 
PR-URL: #60072
Fixes: #59963
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node throws error when require'ing ESM module in TypeScript in nested ESM/CJS context

5 participants

@marco-ippolito @nodejs-github-bot @GeoffreyBooth @ZYSzys @gurgunday