Skip to content

tools: verify signatures when updating nghttp* #60113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2025
Merged

tools: verify signatures when updating nghttp* #60113

merged 1 commit into from
Oct 5, 2025
+12 −7

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 3, 2025

The keyring was generated using:

GNUPGHOME=$(mktemp -d)
GNUPGHOME="$GNUPGHOME" gpg --keyserver keyserver.ubuntu.com --recv-keys 516B622918D15C478AB1EA3A5339A2BE82E07DEC
mv "$GNUPGHOME/pubring.kbx" tools/dep_updaters/nghttp.kbx

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 3, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit eaf6d49 into nodejs:main Oct 5, 2025
30 of 31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eaf6d49

@aduh95 aduh95 deleted the verify-pgp-nghttp-update branch October 5, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @anonrig @cjihrig @richardlau @marco-ippolito