Skip to content

src: fix small compile warning in quic/streams.cc #60118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

src: fix small compile warning in quic/streams.cc #60118

merged 1 commit into from
Oct 6, 2025

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 4, 2025

Fixes: #60110

@jasnell jasnell requested a review from targos October 4, 2025 13:30
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 4, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/69555/ 💛

@codecov

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2025
@jasnell jasnell requested a review from anonrig October 4, 2025 19:48
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit 23fa184 into nodejs:main Oct 6, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 23fa184

@targos targos added the dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. label Oct 6, 2025
@targos
Copy link
Member

targos commented Oct 6, 2025

#59342 (comment)

@richardlau richardlau added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 6, 2025
@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

+1 more reviewer

@NickNaso NickNaso NickNaso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler warnings on quic/streams.cc

8 participants

@jasnell @nodejs-github-bot @targos @NickNaso @addaleax @anonrig @tniessen @richardlau