-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
lib: remove redundant destroyHook checks #60120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gurgunday
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
gurgunday:remove-redundant-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60120 +/- ##
==========================================
+ Coverage 88.45% 88.48% +0.02%
==========================================
Files 703 703
Lines 207826 207822 -4
Branches 40030 40027 -3
==========================================
+ Hits 183842 183889 +47
+ Misses 15973 15940 -33
+ Partials 8011 7993 -18
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Oct 5, 2025
Flarna
approved these changes
Oct 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
process
Issues and PRs related to the process subsystem.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitDestroy
already checks these now:node/lib/internal/async_hooks.js
Lines 533 to 538 in 6f941fc
We are essentially checking the same condition twice
Also the invalid id check didn't cover
undefined
. I don't know if it was intentional, but in any case, since #56966, which removedenroll
, I'm not sure if we can have an undefinedasyncId
anyway