Skip to content

test: skip quic tests that IBM i does not support #60160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

test: skip quic tests that IBM i does not support #60160

merged 1 commit into from
Oct 10, 2025

Conversation

sravani1510
Copy link
Contributor

Similar to AIX, IBM i does not support certain
network flags and we also skip the following
tests like on AIX

  • parallel.test-quic-test-client.mjs
  • parallel.test-quic-test-server.mjs

Refer: #60073

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 8, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (d52cd04) to head (42a5b3a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60160      +/-   ##
==========================================
+ Coverage   88.52%   88.55%   +0.02%     
==========================================
  Files         703      703              
  Lines      207997   207997              
  Branches    40024    40017       -7     
==========================================
+ Hits       184134   184183      +49     
+ Misses      15875    15821      -54     
- Partials     7988     7993       +5

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69617/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69622/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit e105e82 into nodejs:main Oct 10, 2025
69 of 70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e105e82

@sravani1510 sravani1510 deleted the ibmi-skip-test-quic branch October 10, 2025 09:29
@abmusse abmusse added the ibm i Issues and PRs related to the IBM i platform. label Oct 10, 2025
@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sravani1510 @nodejs-github-bot @jasnell @lpinca @cjihrig @richardlau @abmusse