Skip to content

test: correct conditional secure heap flags test #60385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

test: correct conditional secure heap flags test #60385

merged 1 commit into from
Nov 4, 2025
+5 −0

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Oct 24, 2025

Refs #58376

When V8_ENABLE_SANDBOX is true, --secure-heap and --secure-heap-min won't exist in process.allowedNodeEnvironmentFlags.

@codebytere codebytere requested a review from jasnell October 24, 2025 08:55
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (2fb82c8) to head (8f7225e).
⚠️ Report is 125 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60385      +/-   ##
==========================================
- Coverage   88.59%   88.58%   -0.01%     
==========================================
  Files         704      704              
  Lines      208474   207774     -700     
  Branches    40067    40026      -41     
==========================================
- Hits       184696   184056     -640     
+ Misses      15805    15755      -50     
+ Partials     7973     7963      -10

see 129 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69885/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69898/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70033/

@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 53c4a39 into nodejs:main Nov 4, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2025

Landed in 53c4a39

aduh95 pushed a commit that referenced this pull request Nov 5, 2025
@codebytere @aduh95
test: correct conditional secure heap flags test
bc8f7db 
PR-URL: #60385
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere @nodejs-github-bot @lpinca @cjihrig