stream: add bytes() method to stream/consumers #60426
Open
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
H4ad
added
the
semver-minor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60426 +/- ##
==========================================
- Coverage 88.58% 88.54% -0.05%
==========================================
Files 704 703 -1
Lines 207823 208301 +478
Branches 40049 40168 +119
==========================================
+ Hits 184101 184438 +337
- Misses 15772 15868 +96
- Partials 7950 7995 +45
🚀 New features to boost your workflow:
|
wantaekchoi
force-pushed
the
add-stream-consumers-bytes
branch
2 times, most recently
from
3887f53 to
4117fc0
Compare
- Add bytes() method to get Uint8Array from streams - Add tests for bytes() method in PassThrough and ObjectMode scenarios - Update documentation Fixes: nodejs#59542
wantaekchoi
force-pushed
the
add-stream-consumers-bytes
branch
from
4117fc0 to
b6a5a18
Compare
Renegade334
reviewed
Oct 30, 2025
Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
Contributor
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
This LGTM but I'm not explicitly approving it. I don't know why we really need this when user's could do new Uint8Array(await arrayBuffer(stream)); themselves (or rather any conversion from the raw ArrayBuffer).
Contributor
|
Looking at the issue, I see this is meant to align us with the new I'm okay with that then :) nice work! |
Ethan-Arrowood
approved these changes
Nov 3, 2025
Renegade334
reviewed
Nov 3, 2025
Co-authored-by: jakecastelli <38635403+jakecastelli@users.noreply.github.com>
Renegade334
approved these changes
Nov 29, 2025
Renegade334
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jakecastelli
approved these changes
Nov 30, 2025
jakecastelli
added
the
author ready
MattiasBuelens
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream: add bytes() method to stream/consumers
Add a
bytes()method to thestream/consumersmodule that returns a Uint8Array, providing a convenient way to consume streams as typed arrays.Fixes: #59542