Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: support DNS hints in createConnection() #6061

Closed
wants to merge 1 commit into from
Closed

net: support DNS hints in createConnection() #6061

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 5, 2016

Backport of #6000 to v5.x branch.

R= @thealphanerd

@cjihrig
net: support DNS hints in createConnection()
4d109b1 
This commit adds support for passing DNS lookup hints to
createConnection().

PR-URL: nodejs#6000
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	test/parallel/test-net-create-connection.js
@cjihrig cjihrig mentioned this pull request Apr 5, 2016
Merged
3 tasks
@mscdex mscdex added dns Issues and PRs related to the dns subsystem. net Issues and PRs related to the net subsystem. v5.x labels Apr 5, 2016
@MylesBorins MylesBorins assigned GlenTiki and MylesBorins and unassigned GlenTiki Apr 5, 2016
@jasnell
Copy link
Member

jasnell commented Apr 7, 2016

LGTM

@MylesBorins
Copy link
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/2282/

@MylesBorins
Copy link
Contributor

landed in v5.x as 6d9c0c9

@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @jasnell @MylesBorins @mscdex @GlenTiki