Skip to content

test: ensure assertions are reached on more tests #60728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2025
Merged

test: ensure assertions are reached on more tests #60728

merged 1 commit into from
Nov 17, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 15, 2025

Another followup of #60125

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 15, 2025
@codecov
Copy link

codecov bot commented Nov 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (2856475) to head (bf2c88e).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60728      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         703      703              
  Lines      208222   208222              
  Branches    40140    40138       -2     
==========================================
- Hits       184360   184359       -1     
+ Misses      15882    15872      -10     
- Partials     7980     7991      +11

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70185/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 16, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70197/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit ef6b8cc into nodejs:main Nov 17, 2025
79 of 80 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 17, 2025

Landed in ef6b8cc

@aduh95 aduh95 deleted the must-call-mustCalls-t branch November 17, 2025 18:23
targos pushed a commit that referenced this pull request Nov 27, 2025
@aduh95 @targos
test: ensure assertions are reached on more tests
dbb9418 
PR-URL: #60728
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @addaleax @cjihrig