Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix another flaky stringbytes test #6073

Merged
merged 1 commit into from
Apr 6, 2016

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Apr 6, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Avoid depending on precise timing of when an object will be collected
by GC. This test was missed by #6039 as it happened to be in a
different directory than the rest.

Ref: #6039
R=@Trott
CI: https://ci.nodejs.org/job/node-test-pull-request/2172/

@mscdex mscdex added test Issues and PRs related to the tests. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 6, 2016
@Trott
Copy link
Member

Trott commented Apr 6, 2016

LGTM if CI is green

@ofrobots
Copy link
Contributor Author

ofrobots commented Apr 6, 2016

CI looks green apart from some Windows bots that hit environment issues.

Avoid depending on precise timing of when an object will be collected
by GC. This test was missed by nodejs#6039 as it happened to be in a
different directory than the rest.

Ref: nodejs#6039
PR-URL: nodejs#6073
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
@ofrobots ofrobots merged commit b73e1b3 into nodejs:master Apr 6, 2016
@ofrobots
Copy link
Contributor Author

ofrobots commented Apr 6, 2016

Landed as b73e1b3.

@MylesBorins
Copy link
Contributor

@ofrobots this is not landing cleanly in v5.x would you be able to backport?

@MylesBorins
Copy link
Contributor

since this is not landing on v5.x I'm marking as dont-land-on-v5.x

We will still want this backported to v4.x-staging though

@ofrobots
Copy link
Contributor Author

I will take a look soon-ish.

ofrobots added a commit to ofrobots/node that referenced this pull request May 12, 2016
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: nodejs#5945
Ref: nodejs#6039
Ref: nodejs#6073
MylesBorins pushed a commit that referenced this pull request May 13, 2016
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: #5945
Ref: #6039
Ref: #6073

PR-URL: #6705
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: #5945
Ref: #6039
Ref: #6073

PR-URL: #6705
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants