-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
tools: lint Temporal global #60793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
tools: lint Temporal global #60793
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Nov 20, 2025
aduh95
approved these changes
Nov 20, 2025
IlyasShabi
approved these changes
Nov 20, 2025
cjihrig
approved these changes
Nov 20, 2025
LiviaMedeiros
approved these changes
Nov 21, 2025
lpinca
approved these changes
Nov 21, 2025
legendecas
approved these changes
Nov 21, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60793 ✔ Done loading data for nodejs/node/pull/60793 ----------------------------------- PR info ------------------------------------ Title tools: lint Temporal global (#60793) Author René <contact.9a5d6388@renegade334.me.uk> (@Renegade334) Branch Renegade334:lint-temporal-global -> nodejs:main Labels author ready, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 1 - tools: lint Temporal global Committers 1 - Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: https://github.com/nodejs/node/pull/60793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 20 Nov 2025 11:25:12 GMT ✔ Approvals: 7 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/60793#pullrequestreview-3487682563 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/60793#pullrequestreview-3487860076 ✔ - Ilyas Shabi (@IlyasShabi): https://github.com/nodejs/node/pull/60793#pullrequestreview-3488000805 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60793#pullrequestreview-3488584744 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/60793#pullrequestreview-3491583876 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60793#pullrequestreview-3493551923 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/60793#pullrequestreview-3494708544 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/19594848028 |
Contributor
|
Landed in fb6b83c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
dont-land-on-v25.x
PRs that should not land on the v25.x-staging branch and should not be released in v25.x.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.