test: test-tick-processor was failing on mac osx.

[mike-kaufman]

Checklist

• tests and code linting passes
• a test and/or benchmark is included
• the commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

Test was looking for "RunInDebugContext", but output had
"runInDebugContext". Updated pattern to use lower-case r and test passes.

[Trott]

Both strings (runInDebugContext and RunInDebugContext) should show up in out and I think the one that's there now (RunInDebugContext) is the more important one to check for. I'm curious what the value of out is for you that you're not seeing that string. When I run it on OS X, I get (among a lot of other lines) stuff like this:

    641   39.3%   41.9%  node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
     14    1.0%    0.9%  node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
    641   39.3%  node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      6   75.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1   25.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%          node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      2   66.7%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1   50.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1   20.0%      node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%            node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1   50.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%          node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%          node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1   50.0%        node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      2   33.3%      node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%            node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)
      1  100.0%          node::ContextifyContext::RunInDebugContext(v8::FunctionCallbackInfo<v8::Value> const&)

For runInDebugContext, I have these lines:

    353  100.0%      LazyCompile: ~exports.runInDebugContext vm.js:38:37
    280  100.0%      LazyCompile: ~exports.runInDebugContext vm.js:38:37
      6  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%            LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      2  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%        LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%              LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%            LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%            LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
      2  100.0%        LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%              LazyCompile: ~exports.runInDebugContext vm.js:38:37
      1  100.0%            LazyCompile: ~exports.runInDebugContext vm.js:38:37

/cc @nodejs/v8 @matthewloring for comments on which string matters for this test.

[matthewloring]

This looks like a duplicate of #5903/#5911. Does @indutny 's patch #5903 (comment) fix things?

[Fishrock123]

/[rR]unInDebugContext/?

[indutny]

Sorry, but this is not a fix for the problem. Something like #5903 (comment) should be done to fix, I'm working with V8 authorities to resolve this.

[Fishrock123]

👌

[mike-kaufman]

Great. Thanks all. Questions: Is there an ETA on getting the right v8 fix in? And what should be done in the interim given there's a false-failure in the tests?

[indutny]

@mike-kaufman Right now, it is a matter of landing https://codereview.chromium.org/1840633002/ in V8 and cherry-picking it in node.js .

From what I just heard from Michael Achenbach, it looks like nm binary shipped with Xcode may actually support that -f flag. As an interim measure, I would suggest exploring possibility of adding that kind of binary to the PATH env variable when profiling node.js .

[mike-kaufman]

OK, I'll close this and wait for the v8 fix.