tools: do not rewrite npm shebang in install.py #6098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It violates user expectations among other things. The shebang in npm.js is kept as #!/usr/bin/env node. Fixes: nodejs#6095
evanlucas
added
semver-major
mscdex
added
the
npm
|
LGTM |
|
Just making sure I understand what is going on 100%. In the past we would load the file and rewrite it to change the shebang. The change removes the bits that did that leaving the shebang exactly the way it was. If my assumptions are correct LGTM |
|
@thealphanerd correct |
|
LGTM |
|
hmmm failed again. Trying again https://ci.nodejs.org/job/node-test-pull-request/2222/ |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 9, 2016
Rewriting npm shebang in install.py violates user expectations among other things. The shebang in npm.js is kept as #!/usr/bin/env node. Fixes: #6095 PR-URL: #6098 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in 8ffa20c |
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Rewriting npm shebang in install.py violates user expectations among other things. The shebang in npm.js is kept as #!/usr/bin/env node. Fixes: #6095 PR-URL: #6098 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
It violates user expectations among other things.
The shebang in npm.js is kept as #!/usr/bin/env node.
See #6095 for more details