Upgrade to V8 5.0.71.32 in master #6111

ofrobots · 2016-04-08T00:51:07Z

Checklist

tests and code linting passes
the commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

This PR is a rebase of vee-eight-5.0 (+ latest V8 5.0 lkgr) to master.

Normally we wait for V8 version to launch in Chrome stable before landing it onto master. Given that we are planning to start releasing RCs for Node v6 next week, it would be convenient to land V8 5.0 onto master sooner than normal. I expect that V8 5.0 will hit stable within the next couple of weeks.

Ref: #5945, #5766.
R=@nodejs/v8
/cc @nodejs/ctc
~~CI: https://ci.nodejs.org/job/node-test-pull-request/2217/~~ (5.0.71.31)
CI: https://ci.nodejs.org/job/node-test-pull-request/2258/

jasnell · 2016-04-08T03:39:55Z

@nodejs/ctc ... I would like to get this in before cutting the first release candidate for v6 on Monday afternoon but I'd like to get sign off first. If necessary, I can cut the release candidate as a branch off the vee-eight-5.0 branch rebased on the current master but, in general, I think it would be better to go directly off master.

Fishrock123 · 2016-04-08T16:30:54Z

I think it would be safest to make the first RC off a PR/branch like this.

Fishrock123 · 2016-04-08T16:32:16Z

@nodejs/benchmarking Could you run a special run off a branch for comparison, but not actually add to the usual graphs on the website?

Fishrock123 · 2016-04-08T16:33:46Z

CC @nodejs/build something appears wrong with rpi 1: https://ci.nodejs.org/job/node-test-binary-arm/1657/

ERROR: Workspace has a .git repository, but it appears to be corrupt.

rvagg · 2016-04-11T15:30:28Z

Since we have no guarantee that Chromium 50 will go stable in time I think this presents a risk for our schedule and I'd rather not lock it in like this. If 50 doesn't get out during this month then we're going to have to ship with 4.9 and update to 5.0 later on. Locking ourselves in to Chromium's release schedule would be irresponsible when we've put so much work in to communicating our release schedule. So my suggestion is that if you really want to include 5.0 in RC builds then do it off the vee-eight-5.0 branch.

jasnell · 2016-04-11T19:11:14Z

OK. Fortunately and unfortunately I'm behind schedule today so I won't be cutting the v6 RC1 until later this evening or tomorrow (likely tomorrow).

bricss · 2016-04-11T23:13:25Z

Chrome team have bumped canary branch to v52 it means that they should release v50 to stable in next few weeks, I hope so 🐙

ofrobots · 2016-04-13T19:46:45Z

Chrome 50 has launched. http://googlechromereleases.blogspot.com/2016/04/stable-channel-update_13.html

I have already updated this PR to the latest V8 5.0 lkgr. The CI looks green except for flakes.

Fishrock123 · 2016-04-13T19:52:48Z

@ofrobots that means this version is the stable branch? (i.e. 5.0.71.x)

ofrobots · 2016-04-13T19:58:03Z

@Fishrock123 Chrome 50 is shipping with 5.0.71.32, the same as in this PR.

santigimeno · 2016-04-13T20:01:59Z

This is the first time I've seen this test failure in SmartOS:
https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos14-64/2065/

# 
# assert.js:90
#   throw new assert.AssertionError({
#   ^
# AssertionError: 'This is a unicode text: سلام' == ''
#     at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-http-default-encoding.js:36:10)
#     at emitOne (events.js:95:20)
#     at process.emit (events.js:182:7)
#     at process.exit (internal/process.js:79:15)
#     at ClientRequest.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-http-default-encoding.js:31:13)
#     at emitOne (events.js:90:13)
#     at ClientRequest.emit (events.js:182:7)
#     at Socket.socketErrorListener (_http_client.js:306:9)
#     at emitOne (events.js:90:13)
#     at Socket.emit (events.js:182:7)
# connect ECONNREFUSED 127.0.0.1:12346

I don't know if it is related or not though.

ofrobots · 2016-04-13T20:05:41Z

The ECONNREFUSED makes think it is a flake. Relaunched CI: https://ci.nodejs.org/job/node-test-pull-request/2255/

targos · 2016-04-14T04:48:06Z

@ofrobots can you please make sure #6179 is included?

ofrobots · 2016-04-14T06:39:46Z

Added the backport from #6179. New CI: https://ci.nodejs.org/job/node-test-pull-request/2258/.

targos · 2016-04-14T09:40:38Z

LGTM !

bnoordhuis · 2016-04-14T11:14:19Z

Rubber-stamp LGTM. Looks like the ARM failure is a flake; the test uses process.on('uncaughtException') - huge red flag. Are you going to squash the two upgrade commits?

indutny · 2016-04-14T11:19:14Z

Rubber-stamp LGTM

* Pick up the branch head for V8 5.0 stable [1] * Edit v8 gitignore to allow trace_event copy * Update V8 DEP trace_event as per deps/v8/DEPS [2] [1] https://chromium.googlesource.com/v8/v8.git/+/3c67831 [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/4b09207e447ae5bd34643b4c6321bee7b76d35f9 Ref: nodejs#5945 PR-URL: nodejs#6111 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

V8 5.0 introduced a small modification for the unexpected end of input error. PR-URL: nodejs#5945 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

ofrobots · 2016-04-14T17:09:03Z

Thanks.

Squashed, landed as 6e3e8ac...b68827b. The fix from #6179 did not need to be reapplied.

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release. * Buffer * New Buffer constructors have been added [#4682](#4682) * Previously deprecated Buffer APIs are removed [#5048](#5048), [#4594](#4594) * Improved error handling [#4514](#4514) * Cluster * Worker emitted as first argument in 'message' event [#5361](#5361). * Crypto * Improved error handling [#3100](#3100), [#5611](#5611) * Simplified Certificate class bindings [#5382](#5382) * Improved control over FIPS mode [#5181](#5181) * pbkdf2 digest overloading is deprecated [#4047](#4047) * Dependencies * Reintroduce shared c-ares build support [#5775](#5775). * V8 updated to 5.0.71.31 [#6111](#6111). * DNS * Add resolvePtr API to query plain DNS PTR records [#4921](#4921). * Domains * Clear stack when no error handler [#4659](#4659). * File System * The `fs.realpath()` and `fs.realpathSync()` methods have been updated to use a more efficient libuv implementation. This change includes the removal of the `cache` argument and the method can throw new errors [#3594](#3594) * FS apis can now accept and return paths as Buffers [#5616](#5616). * Error handling and type checking improvements [#5616](#5616), [#5590](#5590), [#4518](#4518), [#3917](#3917). * fs.read's string interface is deprecated [#4525](#4525) * HTTP * 'clientError' can now be used to return custom errors from an HTTP server [#4557](#4557). * Modules * Current directory is now prioritized for local lookups [#5689](#5689) * Symbolic links are preserved when requiring modules [#5950](#5950) * Net * DNS hints no longer implicitly set [#6021](#6021). * Improved error handling and type checking [#5981](#5981), [#5733](#5733), [#2904](#2904) * Path * Improved type checking [#5348](#5348). * Process * Introduce process warnings API [#4782](#4782). * Throw exception when non-function passed to nextTick [#3860](#3860). * Readline * Emit key info unconditionally [#6024](#6024) * REPL * Assignment to `_` will emit a warning. [#5535](#5535) * Timers * Fail early when callback is not a function [#4362](#4362) * TLS * Rename 'clientError' to 'tlsClientError' [#4557](#4557) * SHA1 used for sessionIdContext [#3866](#3866) * TTY * Previously deprecated setRawMode wrapper is removed [#2528](#2528). * Util * Changes to Error object formatting [#4582](#4582). * Windows * Windows XP and Vista are no longer supported [#5167](#5167), [#5167](#5167).

* Pick up the branch head for V8 5.0 stable [1] * Edit v8 gitignore to allow trace_event copy * Update V8 DEP trace_event as per deps/v8/DEPS [2] [1] https://chromium.googlesource.com/v8/v8.git/+/3c67831 [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/4b09207e447ae5bd34643b4c6321bee7b76d35f9 Ref: #5945 PR-URL: #6111 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

The following significant (semver-major) changes have been made since the previous Node v5.0.0 release. * Buffer * New Buffer constructors have been added [#4682](#4682) * Previously deprecated Buffer APIs are removed [#5048](#5048), [#4594](#4594) * Improved error handling [#4514](#4514) * Cluster * Worker emitted as first argument in 'message' event [#5361](#5361). * Crypto * Improved error handling [#3100](#3100), [#5611](#5611) * Simplified Certificate class bindings [#5382](#5382) * Improved control over FIPS mode [#5181](#5181) * pbkdf2 digest overloading is deprecated [#4047](#4047) * Dependencies * Reintroduce shared c-ares build support [#5775](#5775). * V8 updated to 5.0.71.31 [#6111](#6111). * DNS * Add resolvePtr API to query plain DNS PTR records [#4921](#4921). * Domains * Clear stack when no error handler [#4659](#4659). * File System * The `fs.realpath()` and `fs.realpathSync()` methods have been updated to use a more efficient libuv implementation. This change includes the removal of the `cache` argument and the method can throw new errors [#3594](#3594) * FS apis can now accept and return paths as Buffers [#5616](#5616). * Error handling and type checking improvements [#5616](#5616), [#5590](#5590), [#4518](#4518), [#3917](#3917). * fs.read's string interface is deprecated [#4525](#4525) * HTTP * 'clientError' can now be used to return custom errors from an HTTP server [#4557](#4557). * Modules * Current directory is now prioritized for local lookups [#5689](#5689) * Symbolic links are preserved when requiring modules [#5950](#5950) * Net * DNS hints no longer implicitly set [#6021](#6021). * Improved error handling and type checking [#5981](#5981), [#5733](#5733), [#2904](#2904) * OS X * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 [#6402](#6402). * Path * Improved type checking [#5348](#5348). * Process * Introduce process warnings API [#4782](#4782). * Throw exception when non-function passed to nextTick [#3860](#3860). * Readline * Emit key info unconditionally [#6024](#6024) * REPL * Assignment to `_` will emit a warning. [#5535](#5535) * Timers * Fail early when callback is not a function [#4362](#4362) * TLS * Rename 'clientError' to 'tlsClientError' [#4557](#4557) * SHA1 used for sessionIdContext [#3866](#3866) * TTY * Previously deprecated setRawMode wrapper is removed [#2528](#2528). * Util * Changes to Error object formatting [#4582](#4582). * Windows * Windows XP and Vista are no longer supported [#5167](#5167), [#5167](#5167).

ofrobots mentioned this pull request Apr 8, 2016

Create vee-eight-5.0 branch (take 2) #5945

Merged

2 tasks

ofrobots force-pushed the v8-5.0.71.31 branch from d9e022a to 6a6f706 Compare April 8, 2016 00:56

mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Apr 8, 2016

Fishrock123 added this to the 6.0.0 milestone Apr 8, 2016

ofrobots force-pushed the v8-5.0.71.31 branch from 6a6f706 to db7a1f7 Compare April 13, 2016 00:32

ofrobots changed the title ~~Upgrade to V8 5.0.71.31 in master~~ Upgrade to V8 5.0.71.32 in master Apr 13, 2016

ofrobots force-pushed the v8-5.0.71.31 branch from 5c03d47 to 5b4bbc6 Compare April 14, 2016 15:39

ofrobots and others added 2 commits April 14, 2016 10:03

test: update error message for JSON.parse

b68827b

V8 5.0 introduced a small modification for the unexpected end of input error. PR-URL: nodejs#5945 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>

ofrobots force-pushed the v8-5.0.71.31 branch from 5b4bbc6 to b68827b Compare April 14, 2016 17:05

ofrobots merged commit b68827b into nodejs:master Apr 14, 2016

ofrobots deleted the v8-5.0.71.31 branch April 14, 2016 17:09

MylesBorins added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 19, 2016

jasnell mentioned this pull request Apr 19, 2016

What is new in v6? #6264

Closed

jasnell mentioned this pull request Apr 26, 2016

2016-04-26, Version 6.0.0 (Current) Release #6383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to V8 5.0.71.32 in master #6111

Upgrade to V8 5.0.71.32 in master #6111

ofrobots commented Apr 8, 2016

jasnell commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

rvagg commented Apr 11, 2016

jasnell commented Apr 11, 2016

bricss commented Apr 11, 2016

ofrobots commented Apr 13, 2016

Fishrock123 commented Apr 13, 2016

ofrobots commented Apr 13, 2016

santigimeno commented Apr 13, 2016

ofrobots commented Apr 13, 2016

targos commented Apr 14, 2016

ofrobots commented Apr 14, 2016

targos commented Apr 14, 2016

bnoordhuis commented Apr 14, 2016

indutny commented Apr 14, 2016

ofrobots commented Apr 14, 2016

Upgrade to V8 5.0.71.32 in master #6111

Upgrade to V8 5.0.71.32 in master #6111

Conversation

ofrobots commented Apr 8, 2016

Checklist

Affected core subsystem(s)

Description of change

jasnell commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

Fishrock123 commented Apr 8, 2016

rvagg commented Apr 11, 2016

jasnell commented Apr 11, 2016

bricss commented Apr 11, 2016

ofrobots commented Apr 13, 2016

Fishrock123 commented Apr 13, 2016

ofrobots commented Apr 13, 2016

santigimeno commented Apr 13, 2016

ofrobots commented Apr 13, 2016

targos commented Apr 14, 2016

ofrobots commented Apr 14, 2016

targos commented Apr 14, 2016

bnoordhuis commented Apr 14, 2016

indutny commented Apr 14, 2016

ofrobots commented Apr 14, 2016